Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Framework 4.6 #12

Closed
rdeago opened this issue Oct 6, 2020 · 0 comments
Closed

Support .NET Framework 4.6 #12

rdeago opened this issue Oct 6, 2020 · 0 comments
Labels
enhancement [issue/PR] requests / implements new or improved functionality.

Comments

@rdeago
Copy link
Member

rdeago commented Oct 6, 2020

Background and motivation

We need to support .NET Framework 4.6 to close Tenacom/ReSharper.ExportAnnotations#20 but it's a no-go while this library only supports .NET Standard 2.0.

We also need to close that issue to solve some of the problems we're having in #11 so we'd better do it by yesterday.

Proposed enhancement

Support .NET Framework 4.6.

Implementation proposals

Add net46 to target frameworks.

Usage examples

Given a .csproj file containing the following:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFrameworks>net46;netcoreapp3.1</TargetFrameworks>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Cecil.XmlDocNames" Version="{NEXT_VERSION}"/>
  </ItemGroup>

</Project>

where {NEXT_VERSION} is a version where this issue has been closed, it should build correctly for both TFMs.

Risks

The net46 TFM could require us to downgrade the code to C# 7.3, thus losing nullable reference types. In that case, we can use ReSharper to check for nullability issues; how to perform the necessary checks in CI remains to be researched.

@rdeago rdeago added enhancement [issue/PR] requests / implements new or improved functionality. v1.x labels Oct 6, 2020
rdeago added a commit to rdeago/Cecil.XmlDocNames that referenced this issue Oct 6, 2020
@rdeago rdeago closed this as completed in 7e57c35 Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [issue/PR] requests / implements new or improved functionality.
Projects
None yet
Development

No branches or pull requests

1 participant