doc: Initial document for oasis architecture design #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyoucao577
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
The doc is excellent! Much clear to me now.
Some more questions:
- What's difference between the
search along routeandcharge station based routingwhen query data from the place layer? Will they call differernt place querying interfaces? - Could you please also describe the data format that build for the querying?(They'll be loaded in the Place layer, right? )
| // TopoQuerier used to return topological information for places | ||
| type TopoQuerier interface { | ||
|
|
||
| // GetNearByPlaces finds near by stations by given placeID and return them in recorded sequence |
There was a problem hiding this comment.
Why recorded sequence? Have they recorded by some topological sequence alreay?
There was a problem hiding this comment.
when recording pre-processed stations, they will be sorted based on some standard, such as based on distance to current station, it will help the caller to do additional filter.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #359
Issue
Targeting issue: the issue will be CLOSED once the PR merged. If there is no issue that addresses the problem, please open a corresponding issue and link it here. Uses the Closes keyword to close them automatically.
CLOSED Architecture design document for OASIS #359
Any other related issue? Mention them here.
Related with Refactor structure of OASIS service #352
Description
Initial document for oasis architecture design, for more information please go to #352 (comment)
Tasklist
Prerequirements