feat:implement local station finder based on google:s2 indexer #278
Conversation
CodeBear801
added
NewFeature
|
Seems there is something wrong with github's actions, CI check also failed for clean branch
|
Poor Github!!! Has re-run the jobs, let's see whether it's ok now. |
| -1) | ||
| sf.bf.getNearbyChargeStations(req) | ||
| return | ||
| } | ||
|
|
||
| func (sf *lowEnergyLocationStationFinder) IterateNearbyStations() <-chan stationfindertype.ChargeStationInfo { | ||
| func (sf *lowEnergyLocationStationFinder) IterateNearbyStations() <-chan *stationfindertype.ChargeStationInfo { |
There was a problem hiding this comment.
Nit: use l instead of sf might be better as convention.
There was a problem hiding this comment.
Copy that, use l or meaningful name.
| var r []stationfindertype.ChargeStationInfo | ||
| var r []*stationfindertype.ChargeStationInfo | ||
|
|
||
| isdoneC := make(chan bool) | ||
| go func() { |
There was a problem hiding this comment.
Why not remove go func(), go with the for loop directly?
| return nil, err | ||
| } | ||
|
|
||
| switch finderType { | ||
|
|
||
| case TNSearchFinder: |
| ) | ||
|
|
||
| // MockChargeStationInfo1 mocks array of *ChargeStationInfo which is compatible with spatialindexer.MockPlaceInfo1 | ||
| var MockChargeStationInfo1 = []*ChargeStationInfo{ |
| @@ -1,6 +1,7 @@ | |||
| package spatialindexer | |||
|
|
|||
| var mockPlaceInfo1 = []*PointInfo{ | |||
| // MockPlaceInfo1 contains 10 PointInfo items | |||
| var MockPlaceInfo1 = []*PointInfo{ | |||
There was a problem hiding this comment.
I want to use which to evaluate result
package A defines some common data structures
package B use that common data structures and returns some result, I use package A's mock result to evaluate whether result is the same as expected.
There was a problem hiding this comment.
Then the B will strongly depends on A, which may should not. Maybe you could write some test packages to test the scenario like this?
Issue
#240
Major changes
Minor changes
<-chan stationfindertype.ChargeStationInfoto<-chan *stationfindertype.ChargeStationInfo, original strategy is easy to create bugs while convert channel result into pointers https://play.golang.org/p/gWgJpEOSuj6To do
spatialindexer.PointInfotospatialindexer.PlaceInfospatialindexer.Locationtonav.LocationStopfunctionality into Station Finder's algorithmsTasklist