Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oasis - Refactor station finder #270

Closed
CodeBear801 opened this issue Apr 9, 2020 · 2 comments
Closed

Oasis - Refactor station finder #270

CodeBear801 opened this issue Apr 9, 2020 · 2 comments
Assignees
Labels
Refactor Rewrite existing code in order to improve its readability, reusability or structure

Comments

@CodeBear801
Copy link

CodeBear801 commented Apr 9, 2020

This task is part of #240

The idea of package stationfinder is finder near by charge stations for given location. It originally supports search by Telenav search service only, after we implement search based on google:s2, we want to provide a general interface for finder's users

@CodeBear801 CodeBear801 added the Refactor Rewrite existing code in order to improve its readability, reusability or structure label Apr 9, 2020
@CodeBear801 CodeBear801 self-assigned this Apr 9, 2020
@CodeBear801
Copy link
Author

CodeBear801 commented Apr 9, 2020

/*

Package stationfinder provide functionality to find nearby charge stations and
related algorithm.
It's find functionality could be achieved by:
- TNSearchFinder, which is implemented by Telenav's search web service.
  + The data source is from professional data
  + Based on Lucence and hilbert value
  + Could potentially supports dynamic information

- LocalIndexerFinder
  + Support any kind of data sources as long as following format defined in https://github.com/Telenav/osrm-backend/issues/237#issue-585201041
  + For Telenav usage, uses the same source with Telenav search service
  + Spatial index is build based on google s2


*/

@CodeBear801
Copy link
Author

Some new item need to change:

  • change the name of tnsearchfinder to cloudfinder
  • change name of NewTnSearchStationFinder to New
  • add protection code in go func() in unit test of orig_station_finder_test.go

More information could go to here: #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Rewrite existing code in order to improve its readability, reusability or structure
Projects
None yet
Development

No branches or pull requests

1 participant