Feature/Implement the tool to generate connectivity map for places #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBear801
added
NewFeature
CodeBear801
commented
Apr 7, 2020
| @@ -24,7 +24,7 @@ func build(points []spatialindexer.PointInfo, minLevel, maxLevel int) map[s2.Cel | |||
| var cellIDs []s2.CellID | |||
| // For level = 30, its parent equal to current | |||
| // So no need append leafCellID into cellIDs outside of for loop | |||
| for i := leafCellID.Level(); i > minLevel; i-- { | |||
| for i := leafCellID.Level(); i >= minLevel; i-- { | |||
| if s.ValidCount == 0 { | ||
| glog.Warningf("connectivity's statistic detect 0 valid result.\n") | ||
| return s | ||
| } |
There was a problem hiding this comment.
More information, please go to: #266
Also add protection in unit tests.
| @@ -105,7 +119,7 @@ func generateTableRequest(center spatialindexer.Location, targets []*spatialinde | |||
|
|
|||
| req.Sources = append(req.Sources, strconv.Itoa(0)) | |||
| pointsCount4Sources := 1 | |||
| for i := startIndex; i <= endIndex; i++ { | |||
| for i := 0; i <= endIndex-startIndex; i++ { | |||
| str := strconv.Itoa(i + pointsCount4Sources) | |||
There was a problem hiding this comment.
More information, please go to: #265
wangyoucao577
approved these changes
Apr 8, 2020
CodeBear801
commented
Apr 8, 2020
| distanceFromOrig: respOrig.Resp.Distances[0][index], | ||
| durationFromOrig: respOrig.Resp.Durations[0][index], | ||
| distanceToDest: respDest.Resp.Distances[index][0], | ||
| durationToDest: respDest.Resp.Durations[index][0], |
| @@ -17,7 +19,7 @@ import ( | |||
| // During pre-processing, its possible to calculate distance between thousands of points, which will | |||
| // cause too big request and might reach potential limitation of different parts. | |||
| // The scenario here is 1-to-N table request, use pointsLimit4SingleTableRequest to limit N | |||
| const pointsThresholdPerRequest = 1000 | |||
| const pointsThresholdPerRequest = 500 | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#238
place-connectivity-generatorincmdcodeTasklist
Requirements / Relations
#231