Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OASIS - table request is not generated correctly #265

Closed
CodeBear801 opened this issue Apr 6, 2020 · 1 comment
Closed

OASIS - table request is not generated correctly #265

CodeBear801 opened this issue Apr 6, 2020 · 1 comment
Assignees
Labels
Bug Something isn't working

Comments

@CodeBear801
Copy link

CodeBear801 commented Apr 6, 2020

Always get failed table response during charge station's connectivity building.

@CodeBear801 CodeBear801 added the Bug Something isn't working label Apr 6, 2020
@CodeBear801 CodeBear801 self-assigned this Apr 6, 2020
@CodeBear801
Copy link
Author

CodeBear801 commented Apr 6, 2020

One bug:

  • Incorrect index during generating table request. Get table request like:
destinations=1001;1002;.... sources=0

while correct one should be

destinations=1;2;.... sources=0

And incorrect start index when generating table request

Place could improve:

  • Log should provide valid information with proper levels
  • While getting table response, should not only check error but also check response code, correct result should has Ok for code.
  • While user pass in url string like url/ internal logic will generate url//uri, duplicate slash is added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant