Fix Electron-app root path detection

[jeffbargmann]

I don't know if there's a more elegant way to do this, but our app was detecting the unix executable within the app package using this module when built for distribution.

The added line resolved, so that the app package itself was always selected.

[jeffbargmann]

(Bump)

[smithalan92]

Hey @JBLatenight , sorry for taking so long to get around to looking at this. Can you give us a bit more information so we can try figure out why the wrong executable was being detected? For example your Electron Version, The original app path that was being detected and how or what you are using to built your app would be a great help.

[jeffbargmann]

Hey @smithalan92 I've been on another project sorry, sure yes these paths turn up the wrong path. Am I missing something perhaps?

/Applications/APP NAME.app/Contents/MacOS/APP NAME
/Applications/APP NAME.app/Contents/Frameworks/APP NAME Helper.app/Contents/MacOS/APP NAME Helper

Each of these should resolve down to

/Applications/APP NAME.app

Otherwise the startup path will point at the MacOS binary (instead of the app), resulting in a variety of bad things.

Thoughts?

[adam-lynch]

@JBLatenight thanks for that.

resulting in a variety of bad things

Please list some. Thanks.

[fritx]

Btw, when I electron app my app.
node-auto-launch would pass in something like

{ path: '/Users/xxx/d/vuee/node_modules/electron-prebuilt/dist/Electron.app/Contents/MacOS/Electron' }

But what we expect is

// with a trailing arg
'..../Electron.app/Contents/MacOS/Electron app'

Otherwise, a default electron app would be opened.
I don't know is it possible to pass such a command instead of an absolute path though.

[adam-lynch]

As far as I know, it's fine to start an app using its inner executable

[sidneys]

@adam-lynch @JBLatenight

This is a great request, as using the inner executable results in the macOS Login Item Preferences showing the inner executable instead of the legit application, which also has the deleterious side-effect of not displaying the icon within the list like all native apps.

This is a usability issue when users want to remove the login item using system preferences.

[johnryan]

Any update on this getting merged? ended up here from #28

[popthestack]

+1 for seeing this merged in. Right now MacOS launches the terminal on login to start my electron app.

[lucasbento]

Since this is opened for more than an year I have forked @JBLatenight project and added the build to github so for those in need of it right now it's possible to do yarn add lucasbento/node-auto-launch (located in https://github.com/lucasbento/node-auto-launch) and use the package normally.

[Alex-D]

What's up @adam-lynch?

[adam-lynch]

Apologies, we've neglected this project a little bit. We're going to fix that though, see #64. I'm going to put in some time this Saturday. If there's any additional information that would make this easier to test / merge, let me know 👍

[adam-lynch]

💥 thanks for that!

@JBLatenight @lucasbento I don't know if you saw #64 but we're looking for people to help out with:

• Improving documentation.
• Troubleshoot, triage, and reproduce issues on your machine.
• Fix bugs.
• General maintenance (dependencies, etc).
• Suggest & add features.
• Review, test, and merge pull-requests from other contributors.
• Anything else you can think of which would help.

Would you be open to that? I can give you access.

[lucasbento]

@adam-lynch: thank you for the proposal and it does seem good but I don't think I'm on my best to help much, so sorry.

Thanks for the work on it, hopefully some good devs will come to help with it as well.