Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac auto launch through LaunchAgent does not work #71

Closed
wmin0 opened this issue Nov 22, 2017 · 8 comments
Closed

Mac auto launch through LaunchAgent does not work #71

wmin0 opened this issue Nov 22, 2017 · 8 comments

Comments

@wmin0
Copy link

wmin0 commented Nov 22, 2017

  • Platform: Mac
  • Node version: 8.5.0
  • auto-launch version: 5.0.3
  • Electron: 1.6.8 main process

According to #34 , if the given path is the path of inner binary, it will be replace to app directory itself.
It may should graceful information in Login Item Preferences.
However, it breaks with LaunchAgent, because LaunchAgent needs inner binary path.

@adam-lynch
Copy link
Contributor

Hey, thanks for reporting this but I can't reproduce it. See the screenshot below:

screen shot 2017-12-02 at 13 10 42

If it's still a problem for you, could you provide an example app which reproduces the problem?

@wmin0
Copy link
Author

wmin0 commented Dec 2, 2017

@adam-lynch I report the bug about LaunchAgent not about LoginItems. I think you should set useLaunchAgent: true.

image

@adam-lynch
Copy link
Contributor

Ah! You're right.

I can reproduce now. I'll be busy today but I might get to it tonight or tomorrow.

cc @JBLatenight @lucasbento.

@adam-lynch adam-lynch reopened this Dec 2, 2017
@adam-lynch
Copy link
Contributor

I just published 5.0.4. Let me know if there are any problems. Thanks again for reporting.

@wmin0
Copy link
Author

wmin0 commented Dec 3, 2017

@adam-lynch Thanks your work 😃

@mavrick
Copy link

mavrick commented Dec 4, 2017

Could we get npm updated with the latest version as well please? 😄

@mavrick
Copy link

mavrick commented Dec 4, 2017

Looks like there is a build issue @adam-lynch https://travis-ci.org/Teamwork/node-auto-launch

@adam-lynch
Copy link
Contributor

Ugh I don't know what happened. I tried to publish just now and it said I can't publish over an existing version. So I published 5.0.5. (Build error is unrelated, that's another branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants