Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] #257 - 대기방 코드 리팩토링 #261

Merged
merged 6 commits into from
Feb 14, 2022
Merged

[Refactor] #257 - 대기방 코드 리팩토링 #261

merged 6 commits into from
Feb 14, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 대기방 네트워크 함수와 UI 함수 분리
  • 이 외 코드 정리
  • 대기방 유저프로필 테두리 추가

📌 참고 사항

📮 관련 이슈

@yangsubinn yangsubinn added 👷Refactor👷‍♂️ 동작변화없이 내부구조 변경 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 labels Feb 13, 2022
@yangsubinn yangsubinn self-assigned this Feb 13, 2022
L-j-h-c
L-j-h-c approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! API 함수 밖으로 셋 함수를 빼니까 훨씬 깔끔해졌네요!!

hyun99999
hyun99999 approved these changes Feb 13, 2022
View reviewed changes
Copy link
Member

@hyun99999 hyun99999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리펙토링 좋았네요~ ✨

Spark-iOS/Spark-iOS/Source/NetworkModels/Room/WaitingRoom.swift
@@ -42,7 +42,7 @@ struct Member: Codable {
struct ReqUser: Codable {
let userID: Int
let nickname: String
let profileImg: String?
let profileImg: String
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요...! 저희가 앱잼내에서는 이렇게 짜지 못했던!

@yangsubinn yangsubinn merged commit 681ce07 into TeamSparker:develop Feb 14, 2022
@yangsubinn yangsubinn deleted the feature/#257 branch February 19, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@hyun99999 hyun99999 hyun99999 approved these changes

Assignees

@yangsubinn yangsubinn

Labels
👷Refactor👷‍♂️ 동작변화없이 내부구조 변경 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] 대기방 코드 리팩토링
3 participants
@yangsubinn @hyun99999 @L-j-h-c