Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] 대기방 코드 리팩토링 #257

Closed
2 tasks done
yangsubinn opened this issue Feb 12, 2022 · 0 comments · Fixed by #261
Closed
2 tasks done

[Refactor] 대기방 코드 리팩토링 #257

yangsubinn opened this issue Feb 12, 2022 · 0 comments · Fixed by #261
Assignees
@yangsubinn
Labels
👷Refactor👷‍♂️ 동작변화없이 내부구조 변경 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아

Comments

@yangsubinn
Copy link
Member

yangsubinn commented Feb 12, 2022 •
edited
Loading

📌 Issue

대기방 리팩토링

  • WaitingVC
  • WaitingCVC

📝 To-do

  • 네트워크 함수와 UI 함수 분리
  • 이 외 코드 정리
@yangsubinn yangsubinn added 👷Refactor👷‍♂️ 동작변화없이 내부구조 변경 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아 labels Feb 12, 2022
@yangsubinn yangsubinn self-assigned this Feb 12, 2022
@yangsubinn yangsubinn changed the title [Refactor] 대기방 네트워크, UI 관련 함수 분리 [Refactor] 대기방 코드 리팩토링 Feb 12, 2022
yangsubinn added a commit to yangsubinn/Spark-iOS that referenced this issue Feb 12, 2022
@yangsubinn
[Chore] TeamSparker#257 - WaitingVC 코드 정리
4283040
yangsubinn added a commit to yangsubinn/Spark-iOS that referenced this issue Feb 12, 2022
@yangsubinn
[Chore] TeamSparker#257 - stopLoadingAnimation 함수 분리
8841324
yangsubinn added a commit to yangsubinn/Spark-iOS that referenced this issue Feb 13, 2022
@yangsubinn
[Feat] TeamSparker#257 - setInitData 함수 분리
a76e895
yangsubinn added a commit to yangsubinn/Spark-iOS that referenced this issue Feb 13, 2022
@yangsubinn
[Chore] TeamSparker#257 - setMemberData 함수 분리
364312e
@yangsubinn yangsubinn mentioned this issue Feb 13, 2022
Merged
yangsubinn added a commit to yangsubinn/Spark-iOS that referenced this issue Feb 14, 2022
@yangsubinn
[Merge] develop pull
dd1b0b4 
Merge branch 'develop' of https://github.com/TeamSparker/Spark-iOS into feature/TeamSparker#257
yangsubinn added a commit to yangsubinn/Spark-iOS that referenced this issue Feb 14, 2022
@yangsubinn
[Chore] TeamSparker#257 - HabitRoomMemberCVC.swift 파일 이름 변경 및 코드 수정
1025d5a
yangsubinn added a commit that referenced this issue Feb 14, 2022
@yangsubinn
Merge pull request #261 from yangsubinn/feature/#257
681ce07 
[Refactor] #257 - 대기방 코드 리팩토링
@hyun99999 hyun99999 mentioned this issue Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangsubinn yangsubinn

Labels
👷Refactor👷‍♂️ 동작변화없이 내부구조 변경 🦹t없e맑은水빈 우리 선배 이젠 타이니하지 않아
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Refactor] #257 - 대기방 코드 리팩토링 yangsubinn/Spark-iOS
1 participant
@yangsubinn