Remove tailing slash from SoundCloud URLs #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
reviewed
Oct 16, 2020
...bi/newpipe/extractor/services/soundcloud/linkHandler/SoundcloudStreamLinkHandlerFactory.java
Show resolved
Hide resolved
Scrxtchy
force-pushed
the
soundcloud-slash
branch
from
b1b0529 to
6a70cb9
Compare
wb9688
approved these changes
Oct 16, 2020
TobiGr
approved these changes
Oct 16, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As researched in the provided issue, SoundCloud do not really support trailing consistently throughout the backend, but work appropriately on the frontend. This change alters NewPipe to remove the trailing slash from any URL, and the streamextractor has been changed to the changed url for fetching content.
Tests have been executed on Android Studio and there appear to be no regressions in functionality