-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soundcloud URLs that end with a slash cannot be parsed correctly #412
Comments
I believe the problem does also lie in here, as the API actually does not like slashes on the end either Lines 120 to 123 in 7505e82
removing the %2F from the encoded url gave a favourable api result, otherwise they just return a empty json object |
This also tied into this line, since when I alter the url, we are still fetching the page based on the original url in Line 49 in ff560e9
|
While testing other issues, I noticed this weird one. I'm under the assumption that soundcloud don't support these completely.
While I can easily substring out the URL from the address when resolving the EmbedPlayer retrieval, that only fixes the error regarding being unable to resolve the ID of the song. Comments will still load, but the stream is marked as unavailable.
I've spent a little amount of time looking into this as it would affect more extraction cleanliness in #410, but I'm having a really troublesome time with breakpoints within Android Studio that this has become quite a nuisance
Reference URLs for testing:
https://soundcloud.com/android52/future-type
https://soundcloud.com/android52/future-type/
The text was updated successfully, but these errors were encountered: