[YouTube] Fix some decryption exceptions by retrying #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
bug
TobiGr
reviewed
Oct 5, 2020
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Show resolved
Hide resolved
|
You haz a test apk? |
|
@opusforlife2 here it is: app-debug.zip |
|
I have tested this apk and no crashes yet. I will confirm it tomorrow after further use. Thanks |
|
I tested this apk file and it looks like the issue has been fixed, the app has not been crashing with me and is working fine. I suggest adding the apk file and linking it to issue #3753 so that people who have the same problem can test it. Thanks |
|
@xibr basically everyone has this problem from time to time ;-) |
|
Branch name is missing in the package ID. Can the extractor branches be read by the build.gradle of the other repo? |
|
@Stypox You're right, for me this apk fixed the problem. Because I can reproduce the problem on Release version 0.20.0 |
4 tasks
TobiGr
reviewed
Oct 15, 2020
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
TobiGr
approved these changes
Oct 15, 2020
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By looking at the HAR from TeamNewPipe/NewPipe#3753 (comment) it seems like YouTube sometimes does not provide the player config object even though it should. In that case the extractor would crash, since it didn't have the needed information to decrypt the signatures. Therefore this PR detects when there is no player config object, and in that case runs the same request again, with at most 3 attempts. This should drastically reduce the number of exceptions caused by YouTube not providing the needed information (e.g. if the probability was 1% before, now it should be 0.0001%. Small, isn't it? ;-) ).
Closes TeamNewPipe/NewPipe#3753