Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app crashes every time I try to open a video, and it doesn't work with background or popup playback too #4451

Closed
4 tasks done
asereze opened this issue Oct 8, 2020 · 19 comments
Labels
bug Issue is related to a bug

Comments

@asereze
Copy link
Contributor

asereze commented Oct 8, 2020

Checklist

Steps to reproduce the bug

  1. Go to any section of the app
  2. Try to open any video
  3. The app crashes

If I try to open a video in NewPipe, any video, the app crashes. If I try to open it in background or in popup playback the app doesn't crash, but the app doesn't manage to open the stream, and it tells me "Could not play this stream".

Logs

Exception

Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Could not load decryption code for the Youtube service.
at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getPlayerUrl(YoutubeStreamExtractor.java:705)
at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.onFetchPage(YoutubeStreamExtractor.java:655)
at org.schabi.newpipe.extractor.Extractor.fetchPage(Extractor.java:56)
at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:68)
at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:64)
at org.schabi.newpipe.util.ExtractorHelper.lambda$getStreamInfo$3(ExtractorHelper.java:116)
at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$5fJcha6Sq5APJBLdG6osaJby-mc.call(Unknown Source:4)
at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
at io.reactivex.Single.subscribe(Single.java:3666)
at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
at io.reactivex.Single.subscribe(Single.java:3666)
at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
at io.reactivex.Maybe.subscribe(Maybe.java:4290)
at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
at io.reactivex.Flowable.subscribe(Flowable.java:14935)
at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
at io.reactivex.Maybe.subscribe(Maybe.java:4290)
at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
at io.reactivex.Single.subscribe(Single.java:3666)
at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:764)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.startsWith(java.lang.String)' on a null object reference
at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getPlayerUrl(YoutubeStreamExtractor.java:700)
... 30 more


Device info

  • Android version/Custom ROM version: LineageOS 16.0 (Android 9.0)
  • Device model: Xiamo Redmi Note 4X
@asereze asereze added the bug Issue is related to a bug label Oct 8, 2020
@asereze asereze changed the title The app crashes every time I try to open a video, and it doesn't work with backround or popup playback too The app crashes every time I try to open a video, and it doesn't work with background or popup playback too Oct 8, 2020
@xibr
Copy link

xibr commented Oct 8, 2020

duplicate of #3753

@opusforlife2
Copy link
Collaborator

Since this user seems to be encountering the error on every try and not just occasionally, it might be a different issue.

Could you try the apk from TeamNewPipe/NewPipeExtractor#406 (comment), @asereze?

@safkhet
Copy link

safkhet commented Oct 9, 2020

I have the exact same issue.

Android version/Custom ROM version: LineageOS 17.1 (Android 10.0)
Device model: One Plus 6T
Don't know if is important, but my device is rooted

@safkhet
Copy link

safkhet commented Oct 9, 2020

Since this user seems to be encountering the error on every try and not just occasionally, it might be a different issue.

Could you try the apk from TeamNewPipe/NewPipeExtractor#406 (comment), @asereze?

Just tested with the debug apk and it works :-)

@safkhet
Copy link

safkhet commented Oct 9, 2020

Since this user seems to be encountering the error on every try and not just occasionally, it might be a different issue.
Could you try the apk from TeamNewPipe/NewPipeExtractor#406 (comment), @asereze?

Just tested with the debug apk and it works :-)

Tested some more and something intriguing happened. As soon as I imported my subscriptions and settings the debug apk started crashing as well. So I tried uninstalling and reinstalling from F-Droid (at this point I did not import subscriptions and settings), and it worked. Then I tried importing only subscriptions, but not the settings and it continued working. I guess there must be something incompatible in my old settings.

@opusforlife2
Copy link
Collaborator

Oh no. This is another one of the bad migration bugs, then.

@wb9688
Copy link
Contributor

wb9688 commented Oct 9, 2020

@opusforlife2: Nope, it's most likely the reCAPTCHA cookies that have expired. #4453 adds a button to clear them. The proper solution would be to also store the expiry date and let it expire then.

@asereze
Copy link
Contributor Author

asereze commented Oct 9, 2020

Could you try the apk from TeamNewPipe/NewPipeExtractor#406 (comment), @asereze?

I tried it now and it seems to work without any issue!

EDIT: If I import subscriptions and settings from the other app the debug one starts crashing as well, like it happened to @safkhet

@opusforlife2
Copy link
Collaborator

@wb9688 This still looks like a migration issue. ^

@Stypox
Copy link
Member

Stypox commented Oct 9, 2020

@safkhet @asereze could you test the apk provided in #4453, and see if after importing settings and clearing the recaptcha cookie everything works fine?

@asereze
Copy link
Contributor Author

asereze commented Oct 10, 2020

@safkhet @asereze could you test the apk provided in #4453, and see if after importing settings and clearing the recaptcha cookie everything works fine?

I didn't find any apk there, where can I download it?

@opusforlife2
Copy link
Collaborator

Yes, @Stypox, where is the apk? 🤭

@Stypox
Copy link
Member

Stypox commented Oct 11, 2020

Mmmh, I just assume every PR has an uploaded apk... then let's wait for @wb9688 to upload one

@wb9688
Copy link
Contributor

wb9688 commented Oct 14, 2020

@Stypox: Done now, next time please don't assume…

@Stypox
Copy link
Member

Stypox commented Oct 14, 2020

Ok, sorry @wb9688 ;-)

@Stypox
Copy link
Member

Stypox commented Oct 17, 2020

Fixed by the reCAPTCHA PR and the Could not load decryption code PR, hopefully

@Stypox Stypox closed this as completed Oct 17, 2020
@opusforlife2
Copy link
Collaborator

Let's ask?

@asereze, please test 0.20.1 and confirm whether your issue is fixed.

@asereze
Copy link
Contributor Author

asereze commented Oct 18, 2020

Let's ask?

@asereze, please test 0.20.1 and confirm whether your issue is fixed.

Yes, it seems to be working fine, now. Thank you!

@opusforlife2
Copy link
Collaborator

Awesome! Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

6 participants