Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced UI design of tempo and pitch adjustment options #9145

Conversation

u7280973
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Enhanced UI design of playback parameters (tempo and pitch) by implementing a more button-like design to improve accessibility.

Before/After Screenshots/Screen Record

  • Before:

image

  • After:

image

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Added red circle button image and day/night version of youtube primary colour.
@TobiGr TobiGr added GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) labels Oct 18, 2022
@opusforlife2
Copy link
Collaborator

The "-/+100%" in the top two circles for Tempo look a bit cramped. Try some other shapes? Maybe squares there as well?

@opusforlife2
Copy link
Collaborator

Thanks for the quick change! Could you update the screenshot?

@u7280973
Copy link
Author

Here is the updated screenshot:
Screen Shot 2022-10-22 at 9 50 02 am

@opusforlife2
Copy link
Collaborator

Does the tappable area correspond to the coloured area? If so, that's a nice accessibility boost, I think.

@Stypox
Copy link
Member

Stypox commented Oct 23, 2022

I don't think these changes look good: the style of the buttons is inconsistent and does not fit well with the app's look. And they also do not increase accessibility that much, since the new buttons do not look more like buttons than before. The problem is that you are not using standard Material Design buttons. Try, for example, the OutlinedButton or the ContainedButton as seen here.

@opusforlife2
Copy link
Collaborator

@u7280973 ANU student?

@opusforlife2
Copy link
Collaborator

Hi. Since a different layout has been decided upon after discussions, this PR is being closed. Please don't hesitate to get in touch if you're interested in working on the proposed design!

@SameenAhnaf
Copy link
Collaborator

@u7280973 Suggested playback speed layout

#8962 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tempo and Pitch adjustment options with a button like design instead of flat text based
5 participants