-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tempo and Pitch adjustment options with a button like design instead of flat text based #8962
Comments
Accessibility-enabled users would probably want easily distinguishable buttons too. |
Hey, could I work on this issue? :)) |
@u7280973 Sure! Could you post a screenshot of your proposed design? |
Looks nice, @u7280973! What about dark theme? And black theme as well, now that I think about it? |
Awesome! Can the red colours be made the same for the seekbar and the buttons, though? The difference isn't noticeable in light theme, but looks weird in the dark theme. Also, the dotted border is rounded in the dark theme. Should be the same across themes, no? |
Great! I think I prefer the sharp corners, but that's a personal preference. Anyway, this is a good point to open a PR. Further discussion can be done there. |
This UI looks like you're supposed to choose between Step and Speed. |
Well, yes, do all sliders need to be shown all the time? |
What I meant is: the UI indicates that you're supposed to switch between 2 menus, 'Speed' and 'Step'. When you say that Speed itself will be a 3-state toggle, then it becomes highly non-intuitive for the user. Choose one. Multi-state toggles, or switchable menus. |
You have a point there. Most of the times one wants to just change one of the sliders at a time. I don't think that exact layout is the best one, but we can work on it. What do you think of this one? Tapping on the "±5%" would bring up a popup menu allowing to choose the step percent (assuming this is an action that the user performs really rarely). Oh, maybe at that point the "unhook" should be given a more explanatory name, e.g. "Tune tempo and pitch independently (may cause distorsions)". The "(may cause distorsions)" part is probably not needed. |
This is also what I had in mind. I don't think this will be difficult to discover. Android has plenty of popup menus indicated by a down arrow. In fact, to make it easier, the entire row/area should be made tappable, so that the user is more likely to accidentally tap it and discover the menu. Having said that, I would like its position more towards the top-right, where Sameen's pic has Step and Speed. It will allow the title "Playback parameters" to be shown. Also, the +-5% button is hard to discover. It could have a border or some other colour to differentiate it.
"Unlink speed and pitch" |
I agree with all of the things you said. Maybe to make the ±5% button more discoverable we could just add a down arrow there, too. |
Let's try that and compare screenshots. |
Looks great! |
I think, tempo drop-down menu should have four options. While accessing the drop-down menu, sliders should be hidden until any option is selected.
|
What does step mean? Why would step be a slider? |
I don't think that would help. Step is for modifying the values shown in the sliders, not actually affecting video playback. So at least one slider should stay visible while the step size is changed for the effect to be clear. |
Suppose, you have chosen a Similarly, the user will be brought to pitch slider if |
That also introduces a problem. If a user wants to change the steps multiple times, they would have to keep changing menus again and again. |
Isn't that problem still persistent in case of #8962 (comment)? Another solution could be making Once the user starts changing tempo or pitch, the step option would be in white text in black background. |
No, there you can easily see the step size change being applied as you tap the arrows. You don't need to change menus if you don't like the current value, you merely tap the % button and select a new one. One thing I'm unaware about is if these are standard Android behaviours. The closer we are to common and standardised behaviour, the better. |
That still involves double click though every single time someone wants to change step.
This is the common behavior as far as I know. I have never seen a separate step toggle except on Newpipe app and its forks. The only disadvantage of the screenshot layout is that the slider is quite big. We can put two checkboxes and |
I like this one. ^ |
It might be more convenient to have fixed playback tempo rate options as buttons and/or as equal value steps. For example, here's a playback speed controls menu from "Global Speed" browser extension: These buttons are customizable presets: Similar example with presets approach is AntennaPod podcast listening app, which has these "tempo / playback speed" controls: Tempo slider could also have snapping to position behavior, where unequal / odd / irregular fractions (e.g. HTML equivalent of that could be |
Checklist
Feature description
The interface here have option to adjust tempo and pitch but they have a flat text based layout instead of some kind of clickable buttons. With little bit of design change there, we can know visualize much better as for now they just look like video statistics menu.
Why do you want this feature?
To enhance the visibility of the tempo and pitch functions giving users the ability to differentiate with ease by having more understanding about the app usability.
Additional information
Just a simple layout change can do wonders for users. Below is just an example.
The text was updated successfully, but these errors were encountered: