-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [FEAT] 홈 배너 UI 구현 #421
Merged
Merged
✨ [FEAT] 홈 배너 UI 구현 #421
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
98fd423
✅ Chore: BannerHeader, Titleheader BaseTVC 상속으로 변경 (#415)
dev-jungbin c4abfd7
➕ Add: HomeBannerTVC (#420)
dev-jungbin 120ec22
Merge remote-tracking branch 'origin' into feature/#420-Home-Banner-UI
dev-jungbin 2949099
➕ Add: Banner Paging icon image (#420)
dev-jungbin ca8e9b6
➕ Add: UIImageView+ setImageColor, setImageUrl 메서드 추가 (#420)
dev-jungbin 818ebe9
➕ Add: 이미지 캐시를 저장할 싱글톤 클래스 ImageCacheManager (#420)
dev-jungbin b948ffe
➕ Add: HomeBannerCVC (#420)
dev-jungbin 2f4df51
✅ Chore: HomeBannerTVC 연결 (#420)
dev-jungbin 37e07ee
✅ Chore: HomeVC TableView Cell Height 설정 (#420)
dev-jungbin 2188023
✅ Chore: Banner CV, CVFlowLayout 선언 (#420)
dev-jungbin 0754f41
✅ Chore: banner에 들어갈 image url 배열 선언 (#420)
dev-jungbin a531cac
✅ Chore: banner CV UI 코드 및 set 함수 작성 (#420)
dev-jungbin 42d340f
✨ Feat: 무한 페이징 적용, segmented control과 연결 (#420)
dev-jungbin 2e253d9
♻️ Refactor: UIPageControl로 리팩토링 (#420)
dev-jungbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기서 UISegmentedControl 말고 기본 UIPageControl을 사용하면 iOS HIG에 기반한 기본 페이징 컨트롤 컴포넌트를 사용해서 구현할 수 있을거 같은데 UISegmentedControl로 구현한 이유가 있나용~??
그 page item들 간에 간격이 너무 커서 고민이라면 그냥 기본 컴포넌트 쓰는것도 좋을 것 같애!!
tintColor / currentPageTintColor로 color 값으로 선택된 페이지, 그렇지 않은 페이지를 표시할 수 있어서 이미지도 사용하지 않아도 되구!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hwangJi-dev 앗. ㅋ ㅋ ㅋ 이거 해주는 애가 있었구나.?.?.?.?.??..?.??.? 바로 리팩 갈길게 거마워... ㅎ.......
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿,,저도 동의합니다!! UIPageControl 추천!! 온보딩에도 얘 써줬어 코드 참고해봐도 좋을듯~!!