✨ [FEAT] 홈 배너 UI 구현 #421
Merged
✨ [FEAT] 홈 배너 UI 구현 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-jungbin
added
📱 View
hwangJi-dev
approved these changes
Aug 9, 2022
Comment on lines
+10
to
+14
| /// 캐시를 저장해 놓을 싱글톤 클래스 | ||
| class ImageCacheManager { | ||
| static let shared = NSCache<NSString, UIImage>() | ||
| private init() {} | ||
| } |
Comment on lines
19
to
29
| private lazy var segmentedControl = UISegmentedControl().then { | ||
| $0.removeAllSegments() | ||
| for i in 0..<bannerImaURLsData.count - 2 { | ||
| $0.insertSegment(with: UIImage(named: "unselectedSegmentImage"), at: i, animated: false) | ||
| } | ||
| $0.setDividerImage(UIImage(), forLeftSegmentState: .normal, rightSegmentState: .normal, barMetrics: .default) | ||
| $0.setBackgroundImage(UIImage(), for: .normal, barMetrics: .default) | ||
| $0.selectedSegmentIndex = 0 | ||
| $0.setImage(UIImage(named: "selectedSegmentImage"), forSegmentAt: $0.selectedSegmentIndex) | ||
| $0.isUserInteractionEnabled = false | ||
| } |
There was a problem hiding this comment.
요기서 UISegmentedControl 말고 기본 UIPageControl을 사용하면 iOS HIG에 기반한 기본 페이징 컨트롤 컴포넌트를 사용해서 구현할 수 있을거 같은데 UISegmentedControl로 구현한 이유가 있나용~??
그 page item들 간에 간격이 너무 커서 고민이라면 그냥 기본 컴포넌트 쓰는것도 좋을 것 같애!!
tintColor / currentPageTintColor로 color 값으로 선택된 페이지, 그렇지 않은 페이지를 표시할 수 있어서 이미지도 사용하지 않아도 되구!!!
There was a problem hiding this comment.
@hwangJi-dev 앗. ㅋ ㅋ ㅋ 이거 해주는 애가 있었구나.?.?.?.?.??..?.??.? 바로 리팩 갈길게 거마워... ㅎ.......
There was a problem hiding this comment.
굿,,저도 동의합니다!! UIPageControl 추천!! 온보딩에도 얘 써줬어 코드 참고해봐도 좋을듯~!!
Comment on lines
90
to
99
| switch pageInt { | ||
| case 0: | ||
| segmentedControl.selectedSegmentIndex = bannerImaURLsData.count - 3 | ||
| bannerCV.scrollToItem(at: [0, bannerImaURLsData.count - 2], at: .left, animated: false) | ||
| case bannerImaURLsData.count - 1: | ||
| segmentedControl.selectedSegmentIndex = 0 | ||
| bannerCV.scrollToItem(at: [0, 1], at: .left, animated: false) | ||
| default: | ||
| segmentedControl.selectedSegmentIndex = pageInt - 1 | ||
| } |
jane1choi
approved these changes
Aug 9, 2022
Comment on lines
19
to
29
| private lazy var segmentedControl = UISegmentedControl().then { | ||
| $0.removeAllSegments() | ||
| for i in 0..<bannerImaURLsData.count - 2 { | ||
| $0.insertSegment(with: UIImage(named: "unselectedSegmentImage"), at: i, animated: false) | ||
| } | ||
| $0.setDividerImage(UIImage(), forLeftSegmentState: .normal, rightSegmentState: .normal, barMetrics: .default) | ||
| $0.setBackgroundImage(UIImage(), for: .normal, barMetrics: .default) | ||
| $0.selectedSegmentIndex = 0 | ||
| $0.setImage(UIImage(named: "selectedSegmentImage"), forSegmentAt: $0.selectedSegmentIndex) | ||
| $0.isUserInteractionEnabled = false | ||
| } |
There was a problem hiding this comment.
굿,,저도 동의합니다!! UIPageControl 추천!! 온보딩에도 얘 써줬어 코드 참고해봐도 좋을듯~!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍎 관련 이슈
closed #420
🍎 변경 사항 및 이유
🍎 PR Point
📸 ScreenShot
Simulator.Screen.Recording.-.iPhone.13.mini.-.2022-08-08.at.01.46.24.mp4