Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ [CHORE] 과방탭 Scroll Indicator 수정 #383

Merged
merged 3 commits into from
Mar 21, 2022
Merged

✅ [CHORE] 과방탭 Scroll Indicator 수정 #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f20346
✅ Chore: 과방탭 tabBar 코드 일괄 수정 (#382)
hwangJi-dev Mar 20, 2022
fa4c673
✅ Chore: 과방 메인뷰 Scroll Indicator 숨김처리 (#382)
hwangJi-dev Mar 20, 2022
fc3ac10
✅ Chore: 과방 정보 상세뷰 Scroll Indicator 보이게 처리 (#382)
hwangJi-dev Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NadoSunbae-iOS/NadoSunbae-iOS/Screen/Classroom/VC/ClassroomMainVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class ClassroomMainVC: BaseVC {

override func viewWillAppear(_ animated: Bool) {
setUpMajorLabel()
tabBarController?.tabBar.isHidden = false
showTabbar()
makeScreenAnalyticsEvent(screenName: "ClassRoom Tab", screenClass: ClassroomMainVC.className)
}
}
Expand Down
3 changes: 2 additions & 1 deletion NadoSunbae-iOS/NadoSunbae-iOS/Screen/Classroom/VC/Info/InfoDetailVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ class InfoDetailVC: BaseVC {
infoDetailTV.allowsSelection = false
infoDetailTV.rowHeight = UITableView.automaticDimension
infoDetailTV.backgroundColor = .paleGray
infoDetailTV.showsVerticalScrollIndicator = true
}
}

Expand Down Expand Up @@ -71,7 +72,7 @@ class InfoDetailVC: BaseVC {
}

override func viewWillAppear(_ animated: Bool) {
self.tabBarController?.tabBar.isHidden = true
hideTabbar()
addKeyboardObserver()
optionalBindingData()
makeScreenAnalyticsEvent(screenName: "ClassRoom_Info Tab", screenClass: InfoDetailVC.className)
Expand Down
2 changes: 1 addition & 1 deletion NadoSunbae-iOS/NadoSunbae-iOS/Screen/Classroom/VC/Question/EntireQuestionListVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class EntireQuestionListVC: BaseVC {

override func viewWillAppear(_ animated: Bool) {
setUpRequestData(sortType: lastSortType)
self.tabBarController?.tabBar.isHidden = false
showTabbar()
makeScreenAnalyticsEvent(screenName: "ClassRoom_Question Tab", screenClass: EntireQuestionListVC.className)
}
}
Expand Down
1 change: 1 addition & 0 deletions NadoSunbae-iOS/NadoSunbae-iOS/Screen/Classroom/VC/Question/QuestionMainVC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class QuestionMainVC: BaseVC {
// MARK: Properties
private let questionSV = UIScrollView().then {
$0.isScrollEnabled = true
$0.showsVerticalScrollIndicator = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴~

}
private let contentView = UIView()
private let personalQuestionLabel = UILabel().then {
Expand Down