Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ [CHORE] 과방탭 Scroll Indicator 수정 #383

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

hwangJi-dev
Copy link
Member

🍎 관련 이슈

closed #382

🍎 변경 사항 및 이유

  • 탭바 코드 함수로 일괄 수정!

🍎 PR Point

  • 과방 메인뷰는 스크롤 인디케이터를 숨기고, 과방 정보 상세뷰는 스크롤 인디케이터를 보이게 처리했습니다!

📸 ScreenShot

Simulator.Screen.Recording.-.iPhone.12.-.2022-03-20.at.17.26.58.mp4

@hwangJi-dev hwangJi-dev added ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용 ✏️ 과방탭 과방탭 개발시 사용합니다. ✅ Chore 자잘한 수정 시 사용합니다. labels Mar 20, 2022
@hwangJi-dev hwangJi-dev requested a review from jane1choi March 20, 2022 08:28
@hwangJi-dev hwangJi-dev self-assigned this Mar 20, 2022
@hwangJi-dev hwangJi-dev requested review from dev-jungbin and jane1choi and removed request for jane1choi and dev-jungbin March 20, 2022 08:29
Copy link
Member

@dev-jungbin dev-jungbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인이염~

@@ -14,6 +14,7 @@ class QuestionMainVC: BaseVC {
// MARK: Properties
private let questionSV = UIScrollView().then {
$0.isScrollEnabled = true
$0.showsVerticalScrollIndicator = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴~

Copy link
Member

@jane1choi jane1choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴이열!! 늦게봐서 미안해ㅠ

@@ -14,6 +14,7 @@ class QuestionMainVC: BaseVC {
// MARK: Properties
private let questionSV = UIScrollView().then {
$0.isScrollEnabled = true
$0.showsVerticalScrollIndicator = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화긴~

@hwangJi-dev hwangJi-dev merged commit 1b00ff7 into develop Mar 21, 2022
@hwangJi-dev hwangJi-dev deleted the chore/#382-Classroom-fix-ScrolllIndicator branch March 21, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Chore 자잘한 수정 시 사용합니다. ✏️ 과방탭 과방탭 개발시 사용합니다. ✨🍕 Jieun 🐰✨ 지은이 연 pr, issue에 사용
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ [CHORE] 과방탭 Scroll Indicator 수정
3 participants