Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add keep watched to liked lists #1832

Merged
merged 27 commits into from
Jun 11, 2024
Merged

Conversation

glensc
Copy link
Collaborator

@glensc glensc commented Feb 24, 2024

Also adds new config:

# Configuration for liked lists
liked_lists:
  # Whether to keep watched items in the list
  keep_watched: false

You can also override keep_watched per list:

# Configuration override for specific lists
liked_list:
  "Saw Collection":
    keep_watched: true

Refs:

@glensc glensc self-assigned this Feb 24, 2024
@glensc glensc requested a review from simonc56 February 24, 2024 12:50
@glensc
Copy link
Collaborator Author

glensc commented Feb 24, 2024

Now I found this not compatible with my own uses. I want some lists to be keep watched and others not.

For example, collections, I would rather keep watched:

but some dynamic lists, I rather do not keep watched:

now question about this is config syntax. how to do that? i was thinking of global config (liked_lists) and overrides per lists (liked_list):

# Configuration for liked lists
liked_lists:
  order: rank
  # Whether to keep watched items in the list
  keep_watched: false

# Configuration override for specific lists
liked_list:
  "The Melchior Collection":
    keep_watched: false
    order: released

comments on section names or syntax?

@glensc glensc added the docs needed Changes in this issue/pull request need to be documented label Feb 24, 2024
@simonc56
Copy link
Collaborator

simonc56 commented Feb 24, 2024

I think this setting should not be added in plextraktsync.
Config file is getting too complicated.

The proper way for this use case is to create Plex smart collections from trakt lists.

In Plex smart collections, you can add a watched filter.

@glensc
Copy link
Collaborator Author

glensc commented Feb 24, 2024

So this whole PR could be replaced with this feature request?

i.e. switch to collections and not have it configurable?

@simonc56
Copy link
Collaborator

simonc56 commented Feb 24, 2024

I see there are smart collections and smart playlists.
I don't know exactly how they are different (testing right now in my Plex client), but indeed I think this is the way.

image

@glensc
Copy link
Collaborator Author

glensc commented Feb 24, 2024

so, summary:

  1. finish Feature request: Sync Trakt Lists as Plex Collections #1667, switch Playlist to Collection (no configuration)
  2. create smart playlist or smart collection from the collections

or the second option can stay manual?

@simonc56
Copy link
Collaborator

simonc56 commented Feb 24, 2024

The API allows to create smart playlist.
So maybe, the 1. can be Sync trakt Lists as Plex Smart Playlists...

Do you know exactly what difference is between smart collection and smart playlist ?

I suggest to discuss it in the feature request #1667

@glensc

This comment was marked as resolved.

@glensc

This comment was marked as resolved.

@glensc

This comment was marked as resolved.

@glensc

This comment was marked as resolved.

@glensc

This comment was marked as resolved.

@glensc
Copy link
Collaborator Author

glensc commented Mar 10, 2024

as refactoring playlists to collections is not getting smooth. and it's also getting complicated there, as can't replace playlists with collections, so need to support both variants (#1667 (comment)).

I'll continue finishing this and adding per list override.

I'm proposing such syntax. I also included example options that could be configured in the future (like order).

# Configuration for liked lists
liked_lists:
  order: rank
  # Whether to keep watched items in the list
  keep_watched: false

# Configuration override for specific lists
liked_list:
  "The Melchior Collection":
    keep_watched: false
    order: released

@glensc glensc force-pushed the keep-watched branch 2 times, most recently from ea82b33 to e1ee701 Compare May 2, 2024 09:55
@glensc glensc marked this pull request as ready for review June 11, 2024 16:50
@glensc glensc merged commit c61f499 into Taxel:main Jun 11, 2024
3 checks passed
@glensc glensc deleted the keep-watched branch June 11, 2024 16:51
@jaredtrouth jaredtrouth mentioned this pull request Jun 14, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs needed Changes in this issue/pull request need to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants