Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createPlaylist does not guard smart=True and non-empty items #1375

Closed
glensc opened this issue Feb 24, 2024 · 2 comments · Fixed by #1377
Closed

createPlaylist does not guard smart=True and non-empty items #1375

glensc opened this issue Feb 24, 2024 · 2 comments · Fixed by #1377

Comments

@glensc
Copy link
Contributor

glensc commented Feb 24, 2024

Describe the Bug

Seems server.createPlaylist(self.name, items=items, smart=True, section=section) does not guard smart=True and non empty items.

While other methods like playlist.removeItems() and playlist.addItems() guard that you do not add items with smart playlist.

The outcome is that created smart playlist doesn't actually contain the items, but something more (haven't figured out what yet, seems like the whole library is added to such smart playlist)

See details of this exploration:

Code Snippets

No response

Expected Behavior

No response

Additional Context

No response

Operating System and Version

Irrelevant

Plex Media Server Version

Irrelevant

Python Version

Irrelevant

PlexAPI Version

4.15.10

@glensc glensc changed the title https://github.com/Taxel/PlexTraktSync/pull/1832#issuecomment-1962421451 createPlaylist does not guard smart=True and non-empty items Feb 24, 2024
@JonnyWong16
Copy link
Collaborator

Thanks, can you submit a fix?

@glensc
Copy link
Contributor Author

glensc commented Feb 26, 2024

#1377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants