Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): remove unnecessary omitted field of MutationObserverOptions #6907

Merged
merged 6 commits into from
Feb 17, 2024
Merged

fix(*): remove unnecessary omitted field of MutationObserverOptions #6907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c62b53
fix(angular-query): remove unnecessary omit parameter
manudeli Feb 16, 2024
e536cdc
Merge branch 'main' into fix/angular-query/type
manudeli Feb 17, 2024
69261b3
fix(*): remove unnecessary omit parameter
manudeli Feb 17, 2024
11b54b9
Merge branch 'main' into fix/angular-query/type
manudeli Feb 17, 2024
2910bf0
Merge branch 'main' into fix/angular-query/type
manudeli Feb 17, 2024
8ceb497
Merge branch 'main' into fix/angular-query/type
TkDodo Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular-query-experimental/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export interface CreateMutationOptions<
TContext = unknown,
> extends Omit<
MutationObserverOptions<TData, TError, TVariables, TContext>,
'_defaulted' | 'variables'
Copy link
Contributor Author

@manudeli manudeli Feb 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no 'variables' field to omit in MutationObserverOptions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All adapters except Vue Query contain this type. So I think it should be changed for all of those?

Copy link
Contributor Author

@manudeli manudeli Feb 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for your eagle eyes 👀🦅

'_defaulted'
> {}

export type CreateMutateFunction<
Expand Down
2 changes: 1 addition & 1 deletion packages/react-query/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export interface UseMutationOptions<
TContext = unknown,
> extends Omit<
MutationObserverOptions<TData, TError, TVariables, TContext>,
'_defaulted' | 'variables'
'_defaulted'
> {}

export type UseMutateFunction<
Expand Down
2 changes: 1 addition & 1 deletion packages/solid-query/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export interface SolidMutationOptions<
TContext = unknown,
> extends Omit<
MutationObserverOptions<TData, TError, TVariables, TContext>,
'_defaulted' | 'variables'
'_defaulted'
> {}

export type CreateMutationOptions<
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte-query/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export type CreateMutationOptions<
> = StoreOrVal<
Omit<
MutationObserverOptions<TData, TError, TVariables, TContext>,
'_defaulted' | 'variables'
'_defaulted'
>
>

Expand Down
Loading