Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): remove unnecessary omitted field of MutationObserverOptions #6907

Merged
merged 6 commits into from
Feb 17, 2024
Merged

fix(*): remove unnecessary omitted field of MutationObserverOptions #6907

merged 6 commits into from
Feb 17, 2024

Conversation

manudeli
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Feb 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2024 9:57am

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 16, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8ceb497. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 16, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8ceb497:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024 •
edited
Loading

Codecov Report

Merging #6907 (8ceb497) into main (137233b) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6907   +/-   ##
=======================================
  Coverage   41.81%   41.81%           
=======================================
  Files         178      178           
  Lines        7017     7017           
  Branches     1418     1418           
=======================================
  Hits         2934     2934           
  Misses       3721     3721           
  Partials      362      362
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 81.75% <ø> (ø)
@tanstack/eslint-plugin-query 85.11% <ø> (ø)
@tanstack/query-async-storage-persister 48.43% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 93.63% <ø> (ø)
@tanstack/query-devtools 4.46% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 93.07% <ø> (ø)
@tanstack/react-query-devtools 0.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 84.84% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 62.68% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.81% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

manudeli
manudeli commented Feb 16, 2024
View reviewed changes
Copy link
Contributor Author

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left my intention

packages/angular-query-experimental/src/types.ts
@@ -137,7 +137,7 @@ export interface CreateMutationOptions<
TContext = unknown,
> extends Omit<
MutationObserverOptions<TData, TError, TVariables, TContext>,
'_defaulted' | 'variables'
Copy link
Contributor Author

@manudeli manudeli Feb 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no 'variables' field to omit in MutationObserverOptions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All adapters except Vue Query contain this type. So I think it should be changed for all of those?

Copy link
Contributor Author

@manudeli manudeli Feb 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for your eagle eyes 👀🦅

@manudeli manudeli marked this pull request as ready for review February 16, 2024 09:14
@manudeli manudeli changed the title fix(angular-query): remove unnecessary omit parameter fix(*): remove unnecessary omit parameter Feb 17, 2024
@manudeli manudeli changed the title fix(*): remove unnecessary omit parameter fix(*): remove unnecessary omitted field of MutationObserverOptions Feb 17, 2024
@manudeli manudeli requested a review from arnoud-dv February 17, 2024 00:44
@TkDodo TkDodo merged commit d9d73ff into TanStack:main Feb 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

@arnoud-dv arnoud-dv Awaiting requested review from arnoud-dv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manudeli @codecov-commenter @TkDodo @arnoud-dv