Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] HTM-1076 | HTM-1077: TMFeatureType event handler to propagate changes to Solr indexes #844

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mprins
Copy link
Contributor

@mprins mprins commented Jun 11, 2024

This adds (synchronous for now) event handlers listening for feature type updates and deletes that will update/delete a Solr index depending on the given change and also update the settings of layers that use the index when applicable.

resolves:

@mprins mprins added the enhancement New feature or request label Jun 11, 2024
@mprins mprins self-assigned this Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 31.32530% with 57 lines in your changes missing coverage. Please review.

Project coverage is 77%. Comparing base (90b0cf0) to head (debc47d).

Files Patch % Lines
...pository/events/SolrTMFeatureTypeEventHandler.java 0% 56 Missing ⚠️
...lormap/api/configuration/dev/PopulateTestData.java 75% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##             main   #844   +/-   ##
=====================================
- Coverage      78%    77%   -0%     
  Complexity     78     78           
=====================================
  Files          95     97    +2     
  Lines        4501   4554   +53     
  Branches      423    426    +3     
=====================================
- Hits         3496   3493    -3     
- Misses        783    839   +56     
  Partials      222    222           
Files Coverage Δ
...b3p/tailormap/api/controller/SearchController.java 75% <100%> (-2%) ⬇️
...rmap/api/controller/admin/SolrAdminController.java 65% <100%> (-3%) ⬇️
...ain/java/nl/b3p/tailormap/api/solr/SolrHelper.java 89% <ø> (ø)
...in/java/nl/b3p/tailormap/api/solr/SolrService.java 100% <100%> (ø)
...lormap/api/configuration/dev/PopulateTestData.java 93% <75%> (-<1%) ⬇️
...pository/events/SolrTMFeatureTypeEventHandler.java 0% <0%> (ø)

Copy link

github-actions bot commented Jun 11, 2024

Test Results

297 tests  +2   296 ✅ +2   3m 39s ⏱️ +18s
 31 suites ±0     1 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 13695d3. ± Comparison against base commit 6c65890.

♻️ This comment has been updated with latest results.

@mprins mprins force-pushed the SpringDataRESTevents branch 2 times, most recently from 06a2695 to bb4e7f9 Compare June 20, 2024 09:10
@mprins mprins force-pushed the SpringDataRESTevents branch from bb4e7f9 to 32eb56d Compare June 26, 2024 08:44
@mprins mprins force-pushed the SpringDataRESTevents branch 9 times, most recently from c4e3f6d to 1d018c3 Compare July 8, 2024 11:47
@mprins mprins force-pushed the SpringDataRESTevents branch 3 times, most recently from 1dab794 to 544b4f4 Compare July 16, 2024 07:30
@mprins mprins force-pushed the SpringDataRESTevents branch from 544b4f4 to debc47d Compare August 6, 2024 13:20
@mprins mprins force-pushed the SpringDataRESTevents branch from debc47d to 5c18f59 Compare August 19, 2024 12:46
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pository/events/SolrTMFeatureTypeEventHandler.java 0% 56 Missing ⚠️

Impacted file tree graph

@@          Coverage Diff          @@
##             main   #844   +/-   ##
=====================================
- Coverage      75%    75%   -0%     
  Complexity     87     87           
=====================================
  Files         115    116    +1     
  Lines        5345   5401   +56     
  Branches      471    474    +3     
=====================================
+ Hits         3993   4005   +12     
- Misses       1107   1153   +46     
+ Partials      245    243    -2     
Files with missing lines Coverage Δ Complexity Δ
...rmap/api/controller/admin/SolrAdminController.java 93% <ø> (ø) 0 <0> (ø)
...c/main/java/org/tailormap/api/solr/SolrHelper.java 83% <ø> (ø) 0 <0> (ø)
...pository/events/SolrTMFeatureTypeEventHandler.java 0% <0%> (ø) 0 <0> (?)

... and 2 files with indirect coverage changes

@mprins mprins force-pushed the SpringDataRESTevents branch 4 times, most recently from 29176a9 to 7731122 Compare August 23, 2024 11:35
@mprins mprins force-pushed the SpringDataRESTevents branch 4 times, most recently from 879a8eb to 8f8ecd3 Compare August 29, 2024 14:27
@mprins mprins force-pushed the SpringDataRESTevents branch 3 times, most recently from 1ca0e79 to 8e3d842 Compare September 2, 2024 09:26
@mprins mprins force-pushed the SpringDataRESTevents branch from 8e3d842 to 4436ac2 Compare September 11, 2024 07:12
mprins added a commit that referenced this pull request Sep 12, 2024
mprins added a commit that referenced this pull request Sep 12, 2024
mprins added a commit that referenced this pull request Sep 13, 2024
mprins added a commit that referenced this pull request Sep 13, 2024
@mprins mprins force-pushed the SpringDataRESTevents branch from 4436ac2 to 2b67f19 Compare September 16, 2024 14:57
@mprins mprins changed the title WIP [HTM-1076][HTM-1077] TMFeatureType event handler to propagate changes to Solr indexes [WIP] HTM-1076: HTM-1077: TMFeatureType event handler to propagate changes to Solr indexes Sep 16, 2024
@mprins mprins force-pushed the SpringDataRESTevents branch 3 times, most recently from c4dc420 to 0b91da1 Compare September 16, 2024 15:58
@mprins mprins force-pushed the SpringDataRESTevents branch 2 times, most recently from eeef5cf to 15da168 Compare October 8, 2024 09:08
@mprins mprins changed the title [WIP] HTM-1076: HTM-1077: TMFeatureType event handler to propagate changes to Solr indexes [WIP] HTM-1076 | HTM-1077: TMFeatureType event handler to propagate changes to Solr indexes Oct 8, 2024
@mprins mprins force-pushed the SpringDataRESTevents branch 2 times, most recently from b1f0be3 to d23e501 Compare October 22, 2024 09:21
@mprins mprins force-pushed the SpringDataRESTevents branch 2 times, most recently from cb4fbf9 to a4fd212 Compare November 3, 2024 11:41
@mprins mprins force-pushed the SpringDataRESTevents branch 2 times, most recently from e9ce108 to dccd219 Compare November 15, 2024 16:22
…nges to solr indexes

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
@mprins mprins force-pushed the SpringDataRESTevents branch from dccd219 to 13695d3 Compare December 1, 2024 06:35
@mprins mprins added the Stale This has not beeen worked on label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale This has not beeen worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant