Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTM-1144: Allow selection of search index for an application layer #876

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

geertplaisier
Copy link
Contributor

No description provided.

@geertplaisier geertplaisier requested a review from mprins July 4, 2024 10:03
@geertplaisier geertplaisier self-assigned this Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Test Results

266 tests  ±0   265 ✅ ±0   2m 56s ⏱️ -29s
 27 suites ±0     1 💤 ±0 
 27 files   ±0     0 ❌ ±0 

Results for commit e2feea2. ± Comparison against base commit 67dde86.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (67dde86) to head (e2feea2).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##             main   #876   +/-   ##
=====================================
+ Coverage      78%    78%   +1%     
  Complexity     78     78           
=====================================
  Files          95     95           
  Lines        4496   4507   +11     
  Branches      420    421    +1     
=====================================
+ Hits         3488   3502   +14     
+ Misses        788    785    -3     
  Partials      220    220           
Files Coverage Δ
...b3p/tailormap/api/controller/SearchController.java 78% <100%> (+5%) ⬆️
...a/nl/b3p/tailormap/api/persistence/GeoService.java 84% <ø> (+1%) ⬆️
...rmap/api/persistence/helper/ApplicationHelper.java 87% <100%> (+1%) ⬆️
...lormap/api/configuration/dev/PopulateTestData.java 93% <90%> (-<1%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mprins mprins merged commit 7c2bd47 into main Jul 4, 2024
5 checks passed
@mprins mprins deleted the dev/HTM-1144 branch July 4, 2024 11:54
mprins added a commit that referenced this pull request Jul 5, 2024
mprins added a commit that referenced this pull request Jul 5, 2024
mprins added a commit that referenced this pull request Jul 8, 2024
mprins added a commit that referenced this pull request Jul 8, 2024
mprins added a commit that referenced this pull request Jul 12, 2024
mprins added a commit that referenced this pull request Jul 15, 2024
mprins added a commit that referenced this pull request Jul 16, 2024
mprins added a commit that referenced this pull request Aug 6, 2024
mprins added a commit that referenced this pull request Aug 19, 2024
mprins added a commit that referenced this pull request Aug 19, 2024
mprins added a commit that referenced this pull request Aug 20, 2024
mprins added a commit that referenced this pull request Aug 22, 2024
mprins added a commit that referenced this pull request Aug 23, 2024
mprins added a commit that referenced this pull request Aug 29, 2024
mprins added a commit that referenced this pull request Aug 29, 2024
mprins added a commit that referenced this pull request Aug 29, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Aug 29, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Aug 30, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Sep 2, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Sep 2, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Sep 11, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Sep 16, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Sep 16, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Sep 16, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Sep 16, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Oct 7, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Oct 8, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Oct 22, 2024
…nges to solr indexes

fix PMD style

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Oct 22, 2024
…nges to solr indexes

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Oct 30, 2024
…nges to solr indexes

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Nov 3, 2024
…nges to solr indexes

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Nov 13, 2024
…nges to solr indexes

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Nov 15, 2024
…nges to solr indexes

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
mprins added a commit that referenced this pull request Dec 1, 2024
…nges to solr indexes

fixup after API changes in #876

move testcases and remove now useless test, use solr service inject

fix rebase issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants