-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: symlink python3, not python, to python3.7 #108
fix: symlink python3, not python, to python3.7 #108
Conversation
72a4315
to
a83f92d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kuanleetri and @tk-woven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, why we need to specifically assign 3? I thought by default is 3.7?
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tk-woven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tk-woven)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! The Docker image uses Ubuntu 18. Python3.6 is the default python3 for Ubuntu18. My understanding from the Dockerfile is that we want to use Python3.7, so we need to set that up manually. Otherwise python3
will point to 3.6.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @tk-woven)
For Ubuntu 18, default python is 2.7 and python3 is 3.x.
a83f92d
to
aa1b031
Compare
Description
This addresses #105 . For Ubuntu 18, default python is 2.7 and python3 is 3.x, so we need to symlink
python3
and notpython
.This change is