Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: symlink python3, not python, to python3.7 #108

Conversation

tk-woven
Copy link
Collaborator

@tk-woven tk-woven commented Aug 3, 2022

Description

This addresses #105 . For Ubuntu 18, default python is 2.7 and python3 is 3.x, so we need to symlink python3 and not python.


This change is Reviewable

@tk-woven tk-woven force-pushed the fix/tyler-kowallis/fix-python-symlink-in-dockerfile branch from 72a4315 to a83f92d Compare August 3, 2022 07:14
Copy link
Collaborator

@chrisochoatri chrisochoatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kuanleetri and @tk-woven)

Copy link
Collaborator

@kuanleetri kuanleetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, why we need to specifically assign 3? I thought by default is 3.7?

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tk-woven)

Copy link
Collaborator

@kuanleetri kuanleetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tk-woven)

Copy link
Collaborator Author

@tk-woven tk-woven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! The Docker image uses Ubuntu 18. Python3.6 is the default python3 for Ubuntu18. My understanding from the Dockerfile is that we want to use Python3.7, so we need to set that up manually. Otherwise python3 will point to 3.6.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tk-woven)

For Ubuntu 18, default python is 2.7 and python3 is 3.x.
@tk-woven tk-woven force-pushed the fix/tyler-kowallis/fix-python-symlink-in-dockerfile branch from a83f92d to aa1b031 Compare August 3, 2022 21:55
@tk-woven tk-woven merged commit 9c1c89b into TRI-ML:master Aug 3, 2022
@tk-woven tk-woven deleted the fix/tyler-kowallis/fix-python-symlink-in-dockerfile branch August 3, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants