Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build-proto and make test fail after following Getting Start instructions #105

Closed
tk-woven opened this issue Aug 3, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@tk-woven
Copy link
Collaborator

tk-woven commented Aug 3, 2022

Description

At the time of this writing, make test fails in the Docker environment after following the getting-started instructions.

Reproduction

docker pull ghcr.io/tri-ml/dgp:master
docker image tag ghcr.io/tri-ml/dgp:master dgp:latest
make docker-start-interactive
# either of the following fail
make build-proto
make test

For example, make test fails with:

root@hostname:/home/dgp# make test
python3 setup.py clean && \
rm -rf build dist && \
find . -name "*.pyc" | xargs rm -f && \
find . -name "__pycache__" | xargs rm -rf
Traceback (most recent call last):
  File "setup.py", line 5, in <module>
    from setuptools import find_packages, setup
ModuleNotFoundError: No module named 'setuptools'
Makefile:33: recipe for target 'clean' failed
make: *** [clean] Error 1

python3 is actually 3.6.9.

root@hostname:/home/dgp# python3
Python 3.6.9 (default, Jun 29 2022, 11:45:57)

but setuptools is installed for 3.7:

root@hostname:/home/dgp# pip show setuptools
Name: setuptools
Version: 63.2.0
Summary: Easily download, build, install, upgrade, and uninstall Python packages
Home-page: https://github.com/pypa/setuptools
Author: Python Packaging Authority
Author-email: [email protected]
License: 
Location: /usr/local/lib/python3.7/dist-packages
Requires: 
Required-by: astroid, grpcio-tools, xarray

Fix

Two solutions: one is to not install Python 3.6 at all so that python3 symlinks to 3.7. Another is to update the Makefile to use python3.7 specifically.

@tk-woven
Copy link
Collaborator Author

tk-woven commented Aug 3, 2022

Fixed in #108.

@tk-woven tk-woven closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants