-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URLs redirects #187
Fix URLs redirects #187
Conversation
@efiring while having accurate URLs in the docs is nice I'm tempted to skip the URL check for now b/c a correct fix should be in the upstream matlab docs, right? |
@ocefpaf I think the corrections you have in Getting corrections upstream is a reasonable goal for the future, but not something I think we should try right now. |
Also, I don't understand why some of the teos-10 urls are failing in the test. Both the original |
Yeah, the redirection works fine in the browser and sporadically here when I re-run the tests. That also failed with both the buggy micromamba and a pure pip solution. I wonder if the 403 is b/c we are hitting that URL multiple times (it is everywhere in the docs). |
7ef0997
to
d74f530
Compare
d74f530
to
f4b8936
Compare
8870146
to
2dad6f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, thank you.
Testing the URL breakages in #185