-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sa_ct_interp and tracer_ct_interp functions to GSW-Python #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great work! This is almost ready to merge. The pre-commit checker (ruff) has 3 complaints that will be trivial to fix:
gsw/interpolation.py:61:16: C419 Unnecessary list comprehension
gsw/interpolation.py:145:16: C419 Unnecessary list comprehension
gsw/tests/test_geostrophy.py:1:1: I001 [*] Import block is un-sorted or un-formatted
If you don't mind, I would like to see this merged as a single squashed commit. Let me know if that is OK, and if you would prefer to squash/rebase it yourself, or have me use one of the github merge options to do it.
@ocefpaf There are now several different modes of test failure, only one of which (the pre-commit ruff check) looks related to the content of the PR. Do you know what is going on? For example, I see micromamba.exe failing, a twine argument error, and perfectly good URLs being rejected by the link checker. |
TL;DR this PR is good to go with just the pre-commit fixes. I'm working on the rest a bit today and should finish tomorrow morning. |
@mauzey1, looking at the output from a slow test (ubuntu-22.04 (aarch64) wheels), I noticed the following compiler warnings:
I would appreciate it if you would provide a PR to GSW-C and a commit to the current PR to clean up those warnings. Given that GSW-C now tests with several compilers, it is possible that additional warnings will turn up, but I don't expect that. |
Eric, @SylvainCorlay's team removed/yanked micromamba 2.0.3 and the CIs should work again as expected. I restart the jobs. |
This will add the MRST-PCHIP interpolation functions added to GSW-C in TEOS-10/GSW-C#73 to the Python library. This will also add the MRST interpolation method option from TEOS-10/GSW-C#74 to geo_strf_dyn_height.