Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Add integration tests for FeedbackResponsesDb #12856

Merged
merged 64 commits into from
Mar 14, 2024
Merged

[#12048] Add integration tests for FeedbackResponsesDb #12856

merged 64 commits into from
Mar 14, 2024

Conversation

xenosf
Copy link
Contributor

@xenosf xenosf commented Feb 28, 2024 •
edited
Loading

Part of #12048

Outline of Solution

xenosf added 30 commits February 12, 2024 15:34
@xenosf
Migrate SessionResultsData
e1955b6
@xenosf
Add default entities
8f0f835
@xenosf
Add helper methods to assist migrated logic
d40f2fb
@xenosf
Migrate buildCompleteGiverRecipientMap
da63d4a
@xenosf
Migrate checkSpecificAccessControl
cc8ff7a
@xenosf
Add default team instance for instructor
a046670
@xenosf
Migrate session results data logic
9b4945b
@xenosf
Use default team entity for instructor instead of const
fb5a808
@xenosf
Migrate non-db logic
cd64a4c
@xenosf
Merge branch 'v9-migration' into v9-migration-GetSessionResultsAction
a78bf65
@xenosf
Refactor Datastore and SQL action logic out to separate methods
97ae4b5
@xenosf
Fix checkstyle errors
51f738f
@xenosf
Migrate DB logic
6573955
@xenosf
Merge branch 'v9-migration' into v9-migration-GetSessionResultsAction
13191fe
@xenosf
Fix checkstyle errors
80d651e
@xenosf
Move default instructor team entity to const
7e960f7
@xenosf
Add test for SqlSessionResultsBundle
901307a
@xenosf
Fix SQL results bundle test
29900bd
@xenosf
Add IT for GetSessionResultsAction
ab20259
@xenosf
Fix action logic
06c6b61
@xenosf
Fix checkstyle errors
0ad3b56
@xenosf
Remove unused method parameters
a23545d
@xenosf
Merge branch 'v9-migration' into v9-migration-GetSessionResultsAction
1aa00a8
@xenosf
Fix persistence issues in test cases
56a9d93
@xenosf
Remove question getter for comment
a5de57d
@xenosf
Rename boolean methods to start with verb
6e62b70
@xenosf
Reword comment to clarify question ID
fa89559
@xenosf
Refactor getting question UUID from param value
273032b
@xenosf
Remove unneeded getters
8627c3f
@xenosf
Remove entities from Const
7f7b81b
@cedricongjh cedricongjh self-requested a review March 3, 2024 19:36
@cedricongjh cedricongjh requested a review from domlimm March 7, 2024 05:55
@domlimm
Copy link
Contributor

domlimm commented Mar 9, 2024 •
edited
Loading

@xenosf Hey xenos, thanks for this! Could you please fix the conflict? Will review when it's fixed. Thank you!

EDIT: it's okay i can review first, will review tonight. Sorry for the delay!

domlimm
domlimm approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Xenos! 💯 Good initiative in creating assertListResponsesEqual 👍🏻

@domlimm domlimm added the s.FinalReview The PR is ready for final review label Mar 9, 2024
@xenosf xenosf mentioned this pull request Mar 12, 2024
Merged
@cedricongjh cedricongjh merged commit 931dea4 into TEAMMATES:master Mar 14, 2024
11 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.1 milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domlimm domlimm domlimm approved these changes

@cedricongjh cedricongjh Awaiting requested review from cedricongjh

Assignees
No one assigned
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
V9.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@xenosf @domlimm @cedricongjh