Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate GetSessionResultsAction #12719

Merged
merged 52 commits into from
Feb 27, 2024
Merged

[#12048] Migrate GetSessionResultsAction #12719

merged 52 commits into from
Feb 27, 2024

Conversation

xenosf
Copy link
Contributor

@xenosf xenosf commented Feb 1, 2024 •
edited
Loading

Part of #12048

Outline of Solution

  • Migrate action access control logic
  • Migrate execute logic
  • Create SqlSessionResultsBundle based on SessionResultsBundle to be used in migrated logic
  • Migrate SessionResultsData methods
  • Migrate relevant FeedbackResponsesLogic & FeedbackResponsesDb methods
  • Migrate relevant FeedbackResponseCommentsLogic & FeedbackResponseCommentsDb methods
  • Add test for SqlSessionResultsBundle and IT for GetSessionResultsAction
  • Create FeedbackMissingResponse class to represent missing responses

@cedricongjh cedricongjh added this to the V9.0.0-beta.0 milestone Feb 2, 2024
@jayasting98 jayasting98 added the s.Ongoing The PR is being worked on by the author(s) label Feb 3, 2024
@xenosf xenosf force-pushed the v9-migration-GetSessionResultsAction branch from ed81535 to 9b4945b Compare February 12, 2024 10:10
@xenosf xenosf force-pushed the v9-migration-GetSessionResultsAction branch from 2cc399b to 901307a Compare February 19, 2024 05:26
kevin9foong
kevin9foong reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@kevin9foong kevin9foong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good effort in migrating the action and the json bundle (which must have taken a lot of effort)!

Just some issues highlighted above with the getters and Const file usage and passing null to Teams.
Looking forward to the fixes and bringing this PR to life!

src/main/java/teammates/common/datatransfer/SqlCourseRoster.java Outdated Show resolved Hide resolved
src/main/java/teammates/common/util/Const.java Outdated Show resolved Hide resolved
src/main/java/teammates/common/util/Const.java Outdated Show resolved Hide resolved
src/test/resources/data/SqlFeedbackSessionResultsBundleTest.json Show resolved Hide resolved
src/test/java/teammates/common/datatransfer/SqlSessionResultsBundleTest.java Show resolved Hide resolved
src/main/java/teammates/storage/sqlentity/FeedbackResponseComment.java Outdated Show resolved Hide resolved
src/main/java/teammates/storage/sqlentity/FeedbackResponseComment.java Outdated Show resolved Hide resolved
src/main/java/teammates/common/datatransfer/SqlCourseRoster.java Outdated Show resolved Hide resolved
src/main/java/teammates/common/datatransfer/SqlCourseRoster.java Outdated Show resolved Hide resolved
domlimm
domlimm reviewed Feb 24, 2024
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xenos, some comments below. Nice work!

src/main/java/teammates/ui/output/SessionResultsData.java Show resolved Hide resolved
src/it/java/teammates/it/ui/webapi/GetSessionResultsActionIT.java Show resolved Hide resolved
@xenosf xenosf changed the base branch from v9-migration to master February 26, 2024 10:53
@xenosf xenosf mentioned this pull request Feb 26, 2024
Merged
cedricongjh
cedricongjh approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the hard work on this!

domlimm
domlimm approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@domlimm domlimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Xenos, very good work. Thank you for doing this! LGTM.

@domlimm domlimm merged commit 2dad48b into TEAMMATES:master Feb 27, 2024
6 of 9 checks passed
@domlimm
Copy link
Contributor

domlimm commented Feb 27, 2024 •
edited
Loading

@xenosf go ahead and merge/rebase for #12849! 😄

@xenosf xenosf mentioned this pull request Feb 28, 2024
Merged
@weiquu weiquu added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricongjh cedricongjh cedricongjh approved these changes

@domlimm domlimm domlimm approved these changes

@kevin9foong kevin9foong Awaiting requested review from kevin9foong

Assignees

@xenosf xenosf

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
6 participants
@xenosf @domlimm @kevin9foong @cedricongjh @weiquu @jayasting98