Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Move accounts JSON for AutomatedSessionRemindersE2ETest #12803

Merged
merged 6 commits into from
Feb 26, 2024
Merged

[#12048] Move accounts JSON for AutomatedSessionRemindersE2ETest #12803

merged 6 commits into from
Feb 26, 2024

Conversation

weiquu
Copy link
Contributor

@weiquu weiquu commented Feb 25, 2024

Part of #12048

EuniceSim142
EuniceSim142 requested changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@EuniceSim142 EuniceSim142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 , other than 1 thing

src/e2e/resources/data/AutomatedSessionRemindersE2ETest_SqlEntities.json Outdated Show resolved Hide resolved
@weiquu weiquu requested a review from EuniceSim142 February 25, 2024 06:39
@EuniceSim142 EuniceSim142 added the s.FinalReview The PR is ready for final review label Feb 25, 2024
@weiquu weiquu requested a review from cedricongjh February 25, 2024 12:59
cedricongjh
cedricongjh approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cedricongjh cedricongjh added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Feb 25, 2024
@weiquu weiquu merged commit e9cdd63 into TEAMMATES:master Feb 26, 2024
6 of 9 checks passed
@cedricongjh cedricongjh added this to the V9.0.0-beta.0 milestone Mar 10, 2024
@weiquu weiquu self-assigned this Mar 10, 2024
@weiquu weiquu added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EuniceSim142 EuniceSim142 EuniceSim142 approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees

@weiquu weiquu

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@weiquu @cedricongjh @EuniceSim142