Skip to content

Commit

Permalink
[#12048] Move accounts JSON for AutomatedSessionRemindersE2ETest (#12803
Browse files Browse the repository at this point in the history
)

* shift accounts json

* revert formatting changes

* Update src/e2e/resources/data/AutomatedSessionRemindersE2ETest_SqlEntities.json

Co-authored-by: EuniceSim142 <[email protected]>

* change testData to sqlTestData

---------

Co-authored-by: EuniceSim142 <[email protected]>
weiquu and EuniceSim142 authored Feb 26, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 500e742 commit e9cdd63
Showing 3 changed files with 13 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -26,7 +26,6 @@ protected void prepareTestData() {
// TODO check if we can automate this checking process

String student1Email = TestProperties.TEST_EMAIL;
testData.accounts.get("instructorWithEvals").setEmail(student1Email);
testData.instructors.get("AutSesRem.instructor").setEmail(student1Email);
testData.students.get("[email protected]").setEmail(student1Email);
testData.feedbackSessions.get("closedSession").setCreatorEmail(student1Email);
@@ -49,6 +48,9 @@ protected void prepareTestData() {
// Published time for one feedback session already set to some time in the past.

removeAndRestoreDataBundle(testData);

sqlTestData = removeAndRestoreSqlDataBundle(loadSqlDataBundle("/AutomatedSessionRemindersE2ETest_SqlEntities.json"));
sqlTestData.accounts.get("instructorWithEvals").setEmail(student1Email);
}

@Override
8 changes: 0 additions & 8 deletions src/e2e/resources/data/AutomatedSessionRemindersE2ETest.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
{
"accounts": {
"instructorWithEvals": {
"googleId": "tm.e2e.AutSesRem.instructor",
"name": "Test Ins for Aut Sessions Reminder",
"email": "[email protected]",
"readNotifications": {}
}
},
"courses": {
"course": {
"id": "tm.e2e.AutSesRem.course",
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"accounts": {
"instructorWithEvals": {
"id": "00000000-0000-4000-8000-000000000001",
"googleId": "tm.e2e.AutSesRem.instructor",
"name": "Test Ins for Aut Sessions Reminder",
"email": "[email protected]",
}
}
}

0 comments on commit e9cdd63

Please sign in to comment.