[#12048] Merge in current v9-migration #12771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix lint * Migrate instructor search indexing worker action * Fix Checkstyle * Fix Checkstyle * Fix Checkstyle * Add testcases * Update comparator to Id --------- Co-authored-by: Cedric Ong <[email protected]> Co-authored-by: Nicolas <[email protected]>
* feat: add tests for CoursesLogic * fix: verify parameters of mocked logic classes * fix: lint issues * fix: add additional verification of parameters --------- Co-authored-by: Cedric Ong <[email protected]>
…12732) * Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade --------- Co-authored-by: Nicolas <[email protected]>
* Add CRUD testcases * Fix linting * Refactor getTypicalComment * Amend testDeleteComment testcase * Amend testDeleteComment testcase * Fix compile error * Revert linting changes --------- Co-authored-by: Nicolas <[email protected]>
* Initial draft for migrated Remove unnecessary comments Remove unnecessary comments Save progress Add draft Add draft * Add tests * Add implementation * Add implementation * Add implementation * Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade * Revert unnecessary changes, add tests * Fix linting and tests * Merge changes with db * Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade * Revert unnecessary changes, add tests * Fix linting and tests * Save progress * Migrate updateFeedbackResponseCascade and deleteFeedbackResponsesAndCommentsCascade Revert unnecessary changes, add tests Fix linting and tests Add changes Revert changes Revert changes Add tests Add lint changes * Fix linting errors * Clean up commits * Disable failing test * Replace giver with updatedAt to make test clearer * Add IT setUp * Save progress on tests * Revert test-related changes * Revert test-related changes, clean linting * Correct spelling mistakes --------- Co-authored-by: Cedric Ong <[email protected]>
* Create Put and Delete Sql Databundle actions * deduplicate courses in GetCoursesAction * add remove and restore sql databundle method to BACKDOOR * Migrate StudentHomePageE2ETest * fix architecture tests * fix tests * Empty-Commit * skip sql data bundle checking * create new class * fix pmd violation * Empty-Commit2 * Empty-Commit3
* Add test for FeedbackSessionsDb * update test cases --------- Co-authored-by: Cedric Ong <[email protected]>
This was referenced Feb 24, 2024
ziqing26
approved these changes
Feb 24, 2024
FergusMok
added
the
c.Epic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Merging in this batch of migration PRs - future PRs will now be made to the main branch instead