Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate FeedbackSessionClosedRemindersAction #12738

Merged
merged 10 commits into from
Feb 20, 2024
Merged

[#12048] Migrate FeedbackSessionClosedRemindersAction #12738

merged 10 commits into from
Feb 20, 2024

Conversation

EuniceSim142
Copy link
Contributor

@EuniceSim142 EuniceSim142 commented Feb 11, 2024 •
edited
Loading

Part of #12048.

Closed emails are only sent to co-owner instructors.

@EuniceSim142 EuniceSim142 added the s.ToReview The PR is waiting for review(s) label Feb 11, 2024
@EuniceSim142 EuniceSim142 added this to the V9.0.0-beta.0 milestone Feb 11, 2024
jayasting98
jayasting98 reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. I am just wondering about a few things related to Hibernate/SQL.

src/main/java/teammates/storage/sqlapi/FeedbackSessionsDb.java Outdated Show resolved Hide resolved
src/main/java/teammates/storage/sqlapi/FeedbackSessionsDb.java Outdated Show resolved Hide resolved
src/main/java/teammates/sqllogic/core/FeedbackSessionsLogic.java Show resolved Hide resolved
@jayasting98 jayasting98 mentioned this pull request Feb 14, 2024
Merged
weiquu
weiquu approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once merge conflicts are fixed!

src/main/java/teammates/sqllogic/core/FeedbackSessionsLogic.java Show resolved Hide resolved
@weiquu weiquu merged commit 2eec90c into TEAMMATES:v9-migration Feb 20, 2024
6 of 7 checks passed
@weiquu weiquu added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayasting98 jayasting98 jayasting98 left review comments

@weiquu weiquu weiquu approved these changes

Assignees

@EuniceSim142 EuniceSim142

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToReview The PR is waiting for review(s)
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EuniceSim142 @weiquu @jayasting98