[#12693] Excess padding on edit course details component #12737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary padding
also added the change in snap file
weiquu
requested changes
Feb 9, 2024
src/web/app/components/course-edit-form/course-edit-form.component.html
Outdated
Show resolved
Hide resolved
weiquu
approved these changes
Feb 10, 2024
domlimm
approved these changes
Feb 10, 2024
cedricongjh
pushed a commit
to cedricongjh/teammates
that referenced
this pull request
Feb 20, 2024
…AMMATES#12737) * Update course-edit-form.component.html Removed unnecessary padding * Update course-edit-form.component.spec.ts.snap also added the change in snap file * Revert "Update course-edit-form.component.spec.ts.snap" This reverts commit 897ac22. * Revert "Update course-edit-form.component.html" This reverts commit d74ac3c. * Update instructor-course-edit-page.component.html --------- Co-authored-by: Abdullah-Sohail100 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12693
Outline of Solution
Change was made to the following file having relative URL as under:
src\web\app\components\course-edit-form\course-edit-form.component.html
Following steps were taken to solve this bug/issue.
PS: This is my first open-source contribution. Before this contribution, I have never worked on this stack. I am looking forward to making more contributions. Thank you all 😀!
Image of updated UI is as under.
