Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excess padding on edit course details component #12693

Closed
domoberzin opened this issue Jan 22, 2024 · 17 comments · Fixed by #12737
Closed

Excess padding on edit course details component #12693

domoberzin opened this issue Jan 22, 2024 · 17 comments · Fixed by #12737
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors

Comments

@domoberzin
Copy link
Contributor

  • Environment:

Steps to reproduce

  1. Go to home page as instructor
  2. Click Instructors tab on a particular course -> Click on View/Edit

Expected behaviour
No excess padding at the bottom of the course details.

Actual behaviour
Excess padding observed at the bottom of the edit course details component.

Additional info

image
@domlimm domlimm added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors labels Jan 22, 2024
Copy link

Good First Issue - Notes for Contributors
This issue is for first-time contributors only. If you are new to TEAMMATES, feel free to submit a PR for this issue.

Please note that we allow only one good first issue per contributor. If you have already made a prior contribution to TEAMMATES, you may wish to take a look at issues with the help wanted tag instead.

We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it.

To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR.

If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum.

@ananyasista
Copy link

Hi! I've never contributed to an open-source project before, but would I be able to take up this issue? If the issue can be corrected through HTML/CSS I should be able to give it a go

@weiquu
Copy link
Contributor

weiquu commented Jan 24, 2024

Hi @ananyasista, yes the fix should be achievable with just HTML/CSS; feel free to submit a PR for this issue

@saloni0419
Copy link

Is anyone working on this #12693 issue @weiquu @domoberzin

@cedricongjh
Copy link
Contributor

hi @saloni0419, let's let @ananyasista submit a PR for this (do let us know if you're not working on it any longer), in the meantime feel free to look into other issues that you're interested in

@pranay911
Copy link

@domlimm Can you please assign this to me?

@domlimm
Copy link
Contributor

domlimm commented Jan 27, 2024

@pranay911 Hi, we do not assign issues. As @ananyasista is working on it, please look for other issues tagged with good first issue for now 😄

@ArunErram
Copy link

can i work on these if it's not done by anyone ?

@cedricongjh
Copy link
Contributor

hi @ArunErram, currently @ananyasista is still working on this issue

@ananyasista do let us know within 3 days if you're still working on this issue, else we'll assign it to the next person in the queue

@ananyasista
Copy link

Hi yes, I'm still working on this issue!

@abdullahsohailcs
Copy link
Contributor

If this doesn't get solved do let me know. I would love to help

@pranay911
Copy link

@ananyasista @domlimm can you please assign this issue to me?

@weiquu
Copy link
Contributor

weiquu commented Feb 5, 2024

Hi @pranay911, we do not assign issues. Since there are others who are waiting / currently working on the issue, I suggest you take a look at some other issue if you still wish to contribute.

@ananyasista do let us know if you need any help - we can take a look at your current implementation if you open a draft PR. Since it has been quite a while, do get back to us within the next 1-2 days, else we'll let @abdullahsohailcs have a shot at it.

@ananyasista
Copy link

Hi! Yes, I'll try to get a PR draft by tonight or tomorrow

@ananyasista
Copy link

@weiquu Actually, I don't think I have the time to complete this issue at the moment. Feel free to pass it on to the next person in line!

@frankgomezdev
Copy link

Looking to make my first (real) contribution to an open-source project. Would I be able to take up this issue?

@abdullahsohailcs
Copy link
Contributor

ok @ananyasista . As @weiquu said earlier I will be taking it from here.

domlimm pushed a commit that referenced this issue Feb 10, 2024
* Update course-edit-form.component.html

Removed unnecessary padding

* Update course-edit-form.component.spec.ts.snap

also added the change in snap file

* Revert "Update course-edit-form.component.spec.ts.snap"

This reverts commit 897ac22.

* Revert "Update course-edit-form.component.html"

This reverts commit d74ac3c.

* Update instructor-course-edit-page.component.html

---------

Co-authored-by: Abdullah-Sohail100 <[email protected]>
cedricongjh pushed a commit to cedricongjh/teammates that referenced this issue Feb 20, 2024
…AMMATES#12737)

* Update course-edit-form.component.html

Removed unnecessary padding

* Update course-edit-form.component.spec.ts.snap

also added the change in snap file

* Revert "Update course-edit-form.component.spec.ts.snap"

This reverts commit 897ac22.

* Revert "Update course-edit-form.component.html"

This reverts commit d74ac3c.

* Update instructor-course-edit-page.component.html

---------

Co-authored-by: Abdullah-Sohail100 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors
Projects
None yet
10 participants