-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12329] Refactoring of sortable tables - notifications table #12717
[#12329] Refactoring of sortable tables - notifications table #12717
Conversation
Hi @domoberzin, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
Folks, This PR seems to be stalling (no activities for the past 74 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
@domoberzin pls pass failing CI |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢 |
Closing this as it is stale, will re-open in future |
Part of #12329
Outline of Solution
This PR refactors the
notification-table
component under the admin pages to utilize thesortable-table
component. Implementation details follow previously merged PRs for different components in the same issues, with the change highlighted below.Addition of Class and Tooltip options to
SortableTableCellData
The notification table maintains more or less the same visual appearance and functionality as it did before these changes.