Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12329] Refactoring of sortable tables - notifications table #12717

Conversation

domoberzin
Copy link
Contributor

Part of #12329

Outline of Solution
This PR refactors the notification-table component under the admin pages to utilize the sortable-table component. Implementation details follow previously merged PRs for different components in the same issues, with the change highlighted below.

Addition of Class and Tooltip options to SortableTableCellData

  • This is required to maintain the behavior of the original notifications table, where there are tooltips for the columns with dates. This change is likely to allow more flexibility in the use of sortable tables as well, though this is applied on a cell-by-cell basis.

The notification table maintains more or less the same visual appearance and functionality as it did before these changes.

Copy link

github-actions bot commented Feb 1, 2024

Hi @domoberzin, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@domoberzin domoberzin changed the title Refactor notifications table to use sortable table [#12329] Refactoring of sortable tables - notifications table Feb 1, 2024
@jayasting98 jayasting98 added the s.Ongoing The PR is being worked on by the author(s) label Feb 3, 2024
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 74 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@mingyuanc
Copy link
Contributor

@domoberzin pls pass failing CI

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 9 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢
Hope someone can get it to move forward again soon...

@domoberzin
Copy link
Contributor Author

Closing this as it is stale, will re-open in future

@domoberzin domoberzin closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.Ongoing The PR is being worked on by the author(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants