Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of sortable tables #12329

Open
3 of 10 tasks
weiquu opened this issue Apr 1, 2023 · 15 comments · Fixed by #12556
Open
3 of 10 tasks

Refactoring of sortable tables #12329

weiquu opened this issue Apr 1, 2023 · 15 comments · Fixed by #12556
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests help wanted Moderate difficulty, small localized change; suitable for novice contributors

Comments

@weiquu
Copy link
Contributor

weiquu commented Apr 1, 2023 •
edited
Loading

Sortable tables are used in several pages, but a fair number of them don't make use of the sortable-table component. Searching sortable amongst .html files should bring up these 10 (unlikely to be more, but best to do a more thorough search):

It would be good to refactor the above components to make use of the sortable-table component to avoid duplication. Some other components, like the contribution question statistics component and the MCQ question statistic component, already make use of that component, so they can be referenced.
@samuelfangjw samuelfangjw added help wanted Moderate difficulty, small localized change; suitable for novice contributors c.Task Other non-user-facing works, e.g. refactoring, adding tests labels Apr 1, 2023
@Sho-Shoo
Copy link
Contributor

Hi! I would like to take this issue as a first-time contributor.

@weiquu
Copy link
Contributor Author

weiquu commented Apr 17, 2023

Hi @Sho-Shoo, we normally recommend issues tagged with good first issue for first-time contributors. However, if you're confident of tackling this issue, you can go ahead and submit a PR for it (:

@mud1tx
Copy link

mud1tx commented Apr 19, 2023

@weiquu Can you please describe the issue once again, I can work on this issue. One more thing what does sortable-table component do?

@weiquu
Copy link
Contributor Author

weiquu commented Apr 19, 2023

Hi @mud1tx, you can find the sortable-table component files and look through them to see what they do and how they do it. As an overview, the sortable-table component, as the name suggests, is a sortable table. Do let me know if you run into any specific issues, and also detail your understanding and what you've tried so that I can better assist.

@mud1tx
Copy link

mud1tx commented Apr 19, 2023

Hi @mud1tx, you can find the sortable-table component files and look through them to see what they do and how they do it. As an overview, the sortable-table component, as the name suggests, is a sortable table. Do let me know if you run into any specific issues, and also detail your understanding and what you've tried so that I can better assist.

I will try working on it today and let you know about it.

@ryalin ryalin mentioned this issue May 7, 2023
Closed
@doreenvalmyr doreenvalmyr mentioned this issue May 7, 2023
Closed
@ZhijieGao829 ZhijieGao829 mentioned this issue May 7, 2023
Closed
@ryalin ryalin mentioned this issue May 7, 2023
Closed
@weiquu weiquu mentioned this issue Jun 7, 2023
Closed
@Zxun2
Copy link
Contributor

Zxun2 commented Jun 26, 2023

Hello! I will like to try refactoring the sessions table component. Is that okay?

@github-actions github-actions bot mentioned this issue Jun 26, 2023
Open
@domlimm
Copy link
Contributor

domlimm commented Jun 26, 2023

@Zxun2 Hello! Feel free to submit a PR 👍🏻

@Zxun2 Zxun2 mentioned this issue Jul 1, 2023
Merged
@singhabhyudita
Copy link
Contributor

Hi, I'll be taking up the Instructor courses page. Hope that's okay?

@github-actions github-actions bot mentioned this issue Jul 23, 2023
Open
weiquu pushed a commit that referenced this issue Jul 24, 2023
@Zxun2
[#12329] Refactoring of sortable tables - Sessions table (#12501)
dacb849 
* refactor(sessions-table): add cell-with-tooltip component

* refactor(sessions-table): add group-buttons component

* refactor(sessions-table): add response-rate component

* refactor(sessions-table): add mvp

* refactor(sessions-table): add enum to header map

* refactor(sessions-table): bug fixes and misc changes

* refactor(sessions-table): fix linting

* fix: linting

* fix: linting max-len

* fix: adjust stylings on response rate

* fix: update failing snapshots

* refactor(sessions-table): add header and table id

* refactor(sessions-table): add setMainTableStyle and optional headers

* feat: update id on sessions table

* fix: update snapshots

* refactor(sessions-table): update optional chaining

* refactor(sessions-table): publish and unpublish behaviour

* fix: linting

* fix: update snapshots

* fix: update id

* fix: reset sorting when retrieving idx

* refactor(sessions-table): rename components

* fix: columns appeared when not expected

* fix: failing e2etests and associated changes

* cleanup(sessions-table):  minor changes

* misc: re-organisation

* fix: linting

* fix: remove e2e stability changes

* misc: revert formatting

* misc: revert formatting-1

* misc: revert formatting-2

* misc: revert formatting-3

* misc: revert formatting-4

* misc: revert formatting-5

* misc: revert formatting-6

* fix: update linting and component tests

* fix: restore individual sessions

* misc: switch initial sort by for instructor home page

* feat: add sort order to sortable table

* fix: linting

* fix: update snapshots

* misc: update stylings

* misc: update snapshots

* misc: update SessionsTableHeaderColorScheme to SortableTableColorScheme

* fix: linting
@weiquu
Copy link
Contributor Author

weiquu commented Jul 24, 2023

Hi, I'll be taking up the Instructor courses page. Hope that's okay?

Sure, do note the changes to the sortable-table component that was introduced in #12501

This was referenced Jul 24, 2023
Open
Open
Open
Open
Open
@domoberzin
Copy link
Contributor

Helllo, could I work on the student list component?

@singhabhyudita singhabhyudita mentioned this issue Jul 30, 2023
Closed
@jasonqiu212
Copy link
Contributor

Helllo, could I work on the student list component?

Sure thing @domoberzin :) Do note the changes introduced by #12501

@domoberzin domoberzin mentioned this issue Jul 31, 2023
Merged
@domoberzin domoberzin mentioned this issue Aug 13, 2023
Closed
@domoberzin domoberzin mentioned this issue Aug 13, 2023
Merged
@RohithSurya
Copy link
Contributor

Hi Guys!!
Letting you know I am working on refactoring notification tables 🙂.

jasonqiu212 added a commit that referenced this issue Sep 22, 2023
@domoberzin @jasonqiu212
[#12329] Refactoring of sortable tables - Extension Confirm Modal (#1…
52b0156 
…2556)

* fix: refactor extension confirm modal to utilise sortable tables

* fix: color scheme

* fix: lint issues

* fix: utilise display value field for transformed data

* fix: add element for table name

* fix: differentiate header class for student and instructor data

* fix: update snapshot

* fix: lint whitespace fixes

* fix: more lint fixes

* fix: hide empty tables

---------

Co-authored-by: Jason Qiu <[email protected]>
jasonqiu212 pushed a commit that referenced this issue Sep 23, 2023
@domoberzin
[#12329] Refactoring of sortable tables - Student list (#12539)
23f92b7
@domoberzin
Copy link
Contributor

Hi, just checking if this issue should be re-opened? Because the remaining subtasks have not yet been completed for the other pages

@weiquu
Copy link
Contributor Author

weiquu commented Jan 17, 2024

Thanks @domoberzin! Good catch

@weiquu weiquu reopened this Jan 17, 2024
@domoberzin domoberzin mentioned this issue Feb 1, 2024
Closed
@Surge747
Copy link

Surge747 commented Oct 19, 2024 •
edited
Loading

Hey I would like to work on this refactoring Issue as a first time contributor
I am an ANU student and as part of coursework we were assigned as a team to contribute to open source projects issues like this one
I noticed this issue had a help wanted and has been stale for a while

Could I be assigned to work on it?
Cheers
Madhav Krishnan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests help wanted Moderate difficulty, small localized change; suitable for novice contributors
Projects
None yet
Milestone
No milestone