[#12494] Allow instructors to use start/end dates up to 12 months in future

[Zxun2]

Fixes #12494

Outline of solution

• Update date range from 3 months to 12 months
• Update comments where necessary
• Add safety net in cases where start date is later than the end date. In which case, the end date automatically defaults to the current start date.

Demo

Safety.net.and.date.range.for.Instructor.Sessions.mp4

[weiquu]

Hi @Zxun2, I'm unable to save a session if I set the start date to be 12 months later... can you take a look? This occurs both when creating a new session and editing a session:

Add safety net in cases where start date is later than the end date. In which case, the end date automatically defaults to the current start date.

Not sure if you want to include time in it as well, or if you think it's not needed:

[cedricongjh]

a few comments, and also I would like to suggest that it might be better from a UX perspective to prevent selection of dates/times on the frontend, rather than surfacing invalid datetimes through the BE as error toasts, but this could be in a seperate PR.

[weiquu]

Did some tests, but haven't taken a detailed look at the code! Just one comment:

• Set opening to 13 Sep 1800h and closing to 15 Sep 1600h => set opening to 16 Sep => closing date changes but time doesn't change, leading to the following:

Think just needs a quick change (: Other than that the behaviour looks good

[weiquu]

2 small nits! Other than that it looks great (: Pinging @domlimm and @cedricongjh for review

[cedricongjh]

lgtm, once the nits by @weiquu are fixed!

[weiquu]

LGTM!

Edit: sorry just spotted a small bug....... will re-review in a bit

[weiquu]

One small edge case to fix!

[weiquu]

LGTM!

[damithc]

@samuelfangjw @zhaojj2209 can we do a release with this feature? I'm receiving more user inquiries about this restriction.