Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow instructors to use start/end dates up to 12 months in future #12494

Closed
damithc opened this issue Jun 25, 2023 · 7 comments · Fixed by #12498
Closed

Allow instructors to use start/end dates up to 12 months in future #12494

damithc opened this issue Jun 25, 2023 · 7 comments · Fixed by #12498
Labels
enhancement New feature or request help wanted Moderate difficulty, small localized change; suitable for novice contributors p.High Significant impact; would like to do in the next few releases

Comments

@damithc
Copy link
Contributor

damithc commented Jun 25, 2023

Current: Instructors cannot choose start/end dates further than 3 months into the future

Suggested: Increase this limit to either 9 or 12 months

Reason: Some instructors set up their courses in advance (e.g., some will set up their fall courses during summer)

Requested by a user.
@damithc damithc added enhancement New feature or request s.ToDiscuss The issue/PR is undergoing discussion/review by the core team labels Jun 25, 2023
@damithc
Copy link
Contributor Author

damithc commented Jun 25, 2023

@wkurniawan07 any cost (or other) downsides if we allow 9 or 12 months for start/end dates?

@github-actions github-actions bot mentioned this issue Jun 25, 2023
Open
@wkurniawan07
Copy link
Member

Not really. In essence the only reason for the limit is abuse prevention, so as long as the limit is sensible it can always be changed.

@damithc
Copy link
Contributor Author

damithc commented Jun 25, 2023

Not really. In essence the only reason for the limit is abuse prevention, so as long as the limit is sensible it can always be changed.

Thanks for the confirmation @wkurniawan07

Let's set it to 12 months then, as 9 feels a bit random.

@damithc damithc added help wanted Moderate difficulty, small localized change; suitable for novice contributors and removed s.ToDiscuss The issue/PR is undergoing discussion/review by the core team labels Jun 25, 2023
@Zxun2
Copy link
Contributor

Zxun2 commented Jun 26, 2023 •
edited
Loading

Hello! May I work on this issue? Edit: I have submitted a PR

@Zxun2 Zxun2 mentioned this issue Jun 29, 2023
Merged
@damithc
Copy link
Contributor Author

damithc commented Jun 29, 2023

Thanks for taking this up @Zxun2
Yes, I would like to release this fix to users soon, as I'm receiving more user requests for this.

@damithc damithc added the p.High Significant impact; would like to do in the next few releases label Jun 29, 2023
@sawilkhan
Copy link

Is the issue still open?

@domlimm
Copy link
Contributor

domlimm commented Jul 6, 2023

@sawilkhan Thank you for your interest! Unfortunately, it is being worked on by someone else. Please look for another issue 👍🏻

weiquu added a commit that referenced this issue Jul 12, 2023
@Zxun2 @domlimm @weiquu
[#12494] Allow instructors to use start/end dates up to 12 months in …
930c2b1 
…future (#12498)

* feat: add safety net for invalid dates

* feat: update start/end dates from 3 to 12 months

* perf: reduce side effects

* fix: update error message

* feat: add safety net for time

* feat: testcase for `getInstantMonthsOffsetFromNow`

* fix: failing component tests

* refactor(sessions-edit-form): abstract model to base class

* fix: linting

* fix: inaccurate end time when start date > end date

* misc: update javadocs

* misc: change twelve to 12

* fix: update missing attribute

* fix: add missing edge case

* fix: add missing edge case when startDate > endDate and hours are equal

---------

Co-authored-by: Dominic Lim <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Moderate difficulty, small localized change; suitable for novice contributors p.High Significant impact; would like to do in the next few releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12494] Allow instructors to use start/end dates up to 12 months in future Zxun2/teammates
5 participants
@damithc @wkurniawan07 @domlimm @Zxun2 @sawilkhan