Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12383] Instructor edit feedback session page: missing indication for tooltip #12384

Merged
merged 4 commits into from
Apr 19, 2023
Merged

[#12383] Instructor edit feedback session page: missing indication for tooltip #12384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b16c252
Instructor edit feedback session page: missing indication for tooltip…
Apr 16, 2023
529e2da
changes for tool-tip class and test case fix as requested as test cas…
Apr 16, 2023
83a1b6a
Fixing tooltip indication issue for Multiple Select Answers
Apr 17, 2023
5d61647
Merge branch 'master' into FixingTooltip#12383
zhaojj2209 Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ion-edit-details-form/__snapshots__/mcq-question-edit-details-form.component.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ exports[`McqQuestionEditDetailsFormComponent should snap when questionDropdownEn
class="form-check form-check-inline"
>
<label
class="form-check-label fw-bold"
class="form-check-label ngb-tooltip-class fw-bold"
container="body"
ngbtooltip="Assign weights to the choices for calculating statistics."
>
Expand Down Expand Up @@ -204,7 +204,7 @@ exports[`McqQuestionEditDetailsFormComponent should snap when questionDropdownEn
class="form-check form-check-inline"
>
<label
class="form-check-label fw-bold"
class="form-check-label ngb-tooltip-class fw-bold"
container="body"
ngbtooltip="Assign weights to the choices for calculating statistics."
>
Expand Down Expand Up @@ -367,7 +367,7 @@ exports[`McqQuestionEditDetailsFormComponent should snap with default view i.e.
class="form-check form-check-inline"
>
<label
class="form-check-label fw-bold"
class="form-check-label ngb-tooltip-class fw-bold"
container="body"
ngbtooltip="Assign weights to the choices for calculating statistics."
>
Expand Down
5 changes: 3 additions & 2 deletions ...s/question-types/question-edit-details-form/mcq-question-edit-details-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@
<div class="col-md-6">
<div class="col-md-12">
<div class="form-check form-check-inline" *ngIf="!isGeneratedOptionsEnabled">
<label class="form-check-label fw-bold" ngbTooltip="Assign weights to the choices for calculating statistics."
<label class="form-check-label ngb-tooltip-class fw-bold" ngbTooltip="Assign weights to the choices for calculating statistics."
container="body">
<input id="weights-checkbox" class="form-check-input" type="checkbox" [ngModel]="model.hasAssignedWeights"
[disabled]="!isEditable"
(ngModelChange)="triggerWeightsColumn($event)">
(ngModelChange)="triggerWeightsColumn($event)"
>
Options are weighted
</label>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ...s/question-types/question-edit-details-form/msq-question-edit-details-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="col-md-6">
<div class="col-md-12">
<div class="form-check form-check-inline" *ngIf="!isGeneratedOptionsEnabled">
<label class="form-check-label fw-bold" ngbTooltip="Assign weights to the choices for calculating statistics."
<label class="form-check-label ngb-tooltip-class fw-bold" ngbTooltip="Assign weights to the choices for calculating statistics."
container="body">
<input id="weights-checkbox" class="form-check-input" type="checkbox" [ngModel]="model.hasAssignedWeights"
[disabled]="!isEditable" (ngModelChange)="triggerWeightsColumn($event)">
Expand Down