-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12383] Instructor edit feedback session page: missing indication for tooltip #12384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rai31218, thank you for your PR.
However, it appears that there are test cases failing, do fix the tests and re-request a review once that is done, thank you!
The proper way is to update the snapshots by running npm run test
and pressing a
to run all test cases. After that, check through the snapshots to make sure the changes are as expected, then press u
to update them. You can find more details on snapshot testing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for your contribution to TEAMMATES
One thing missed out in the original issue was that this same issue also exists for the MCQ (multiple answer) question. Can we do the same fix there as well? |
Hi @zhaojj2209 , you mean Multiple Select Questions? |
Yes, thanks @zhaojj2209 for pointing it out!
Yes, please re-request for review after the change has been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
Fixes #12383
Added ngbTooltip to add the tooptip in "Options are weighted" option in checkbox and using ngb-tooltip-class css class