Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12383] Instructor edit feedback session page: missing indication for tooltip #12384

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

rai31218
Copy link
Contributor

@rai31218 rai31218 commented Apr 16, 2023

Fixes #12383

Added ngbTooltip to add the tooptip in "Options are weighted" option in checkbox and using ngb-tooltip-class css class

@cedricongjh cedricongjh self-requested a review April 16, 2023 18:24
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rai31218, thank you for your PR.

However, it appears that there are test cases failing, do fix the tests and re-request a review once that is done, thank you!

The proper way is to update the snapshots by running npm run test and pressing a to run all test cases. After that, check through the snapshots to make sure the changes are as expected, then press u to update them. You can find more details on snapshot testing here.

@rai31218 rai31218 requested a review from cedricongjh April 16, 2023 22:03
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution to TEAMMATES

@cedricongjh cedricongjh requested a review from zhaojj2209 April 17, 2023 04:21
@cedricongjh cedricongjh added the s.FinalReview The PR is ready for final review label Apr 17, 2023
@zhaojj2209
Copy link
Contributor

One thing missed out in the original issue was that this same issue also exists for the MCQ (multiple answer) question. Can we do the same fix there as well?

@rai31218
Copy link
Contributor Author

Hi @zhaojj2209 , you mean Multiple Select Questions?
We can do that. After pushing shall I re-request review ?

@weiquu
Copy link
Contributor

weiquu commented Apr 17, 2023

Hi @zhaojj2209 , you mean Multiple Select Questions?

Yes, thanks @zhaojj2209 for pointing it out!

We can do that. After pushing shall I re-request review ?

Yes, please re-request for review after the change has been made

@rai31218 rai31218 requested a review from cedricongjh April 17, 2023 10:24
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@zhaojj2209 zhaojj2209 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Apr 19, 2023
@zhaojj2209 zhaojj2209 merged commit 205e652 into TEAMMATES:master Apr 19, 2023
@samuelfangjw samuelfangjw added this to the V8.28.0 milestone Jul 14, 2023
@samuelfangjw samuelfangjw added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructor edit feedback session page: missing indication for tooltip
5 participants