Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-schema dependency to avoid errors in Meteor 1.3 #147

Closed
martijnwalraven opened this issue Feb 26, 2016 · 2 comments
Closed

Comments

@martijnwalraven
Copy link

We've had to remove a workaround in Meteor 1.3, which leads to the issue previously reported in #104 reappearing:

toEnd: wrong arguments-i18n-compiler` fr...  /

to: wrong arguments

This is due to shelljs (which is a dependency of the Cordova packages we use) modifying String.prototype to add to and toEnd functions, and this conflicting with the stringjs. The current version of tap:i18n depends on simple-schema 1.3.0, which has a dependency on stringjs.

I don't know enough about this project and the reasons for depending on an older version of simple-schema, but is there any way you could upgrade?

Since simple-schema has now removed the string.js dependency, that would at least solve the issue until this has been fixed in shelljs and the Cordova packages that use it have updated their dependencies.

@theosp
Copy link
Collaborator

theosp commented Feb 26, 2016

Which simple-schema version to try upgrade to/test with?

@martijnwalraven
Copy link
Author

I would try the most recent version, but at least the one after the string.js dependency was removed.

Sent from my iPhone

On 26 Feb 2016, at 18:08, Daniel C [email protected] wrote:

Which simple-schema version to try test with?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants