Remove stringjs dependency #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the awesome PR @marcodejongh! I have been wanting to do this for awhile. I will get this released soon along with some other changes I'm making. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @aldeed,
Takes for the amazing package been using it for a while now (Meteor 0.6 or so). Lately I've been experimenting with Electron and kept bumping my head into #317. So I figured I might as well fix it instead of implementing the work around.
So here it is, I've used native String methods where possible and added Polyfills to ensure it works in all browsers (trim is only supported starting IE 9+ 😭 ).
I deemed the humanize function not worthy of it's own proxy package all though it would be possible if you want to keep the codebase cleaner. So I've included https://github.com/jxson/string-capitalize https://github.com/jxson/string-humanize in the
string-humanize.jsfile It's the same humanize method as in string.js.Watchout: this PR also includes #479 which I needed to be able to run the tests