-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gene essentiality check using DepMap #574
Conversation
…ion. I don't think that code had ever been run, it was just not right.
…urrently only processes the model available in the repo, and does not compare with any older model version. The code is however prepared for comparing versions. Currently, it only processes 2 out of 40 chunks of data, this is to be changed when we want to run a full evaluation with 891 cell lines.
looks good - except that it suppose to be started from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I've left some aesthetic comments.
In terms of the bigger picture, what is the aim here? To be able to run this once, now and again? Or more often, say with every other release?
I had to do that, I needed the code from that PR before it was approved. We did like this often in GECKO3. I'm thinking we can do like this? |
I'm thinking it is twofold - both at every release but also as a oneoff for generating a figure for the paper. In the second case, it takes some tweaking. This is why I left some commented out code, it will be useful for that purpose. |
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
Co-authored-by: Mihail Anton <[email protected]>
this is fine - To avoid confusion, maybe clarify in PR message that the code is based on that PR? |
Done |
I would say with the larger essentiality check for DepMap data should be performed every major release in the main branch. But for each PR, then we can run a smaller scale test as Hao committed in #563 |
sounds a reasonable plan given the heavy computation load of DeepMap data |
Great! Perhaps this should be added to https://github.com/SysBioChalmers/Human-GEM/wiki/How-to-make-a-new-release so as not to forget about this step. |
Co-authored-by: Mihail Anton <[email protected]>
Very nice, @mihai-sysbio, I had not seen this before. It solves the problem! |
Co-authored-by: Mihail Anton <[email protected]>
Through the previous commit a07b7b6, the file |
✅ |
I think this is ready for merging. |
Main improvements in this PR:
Added evaluation of gene essentiality using DepMap data. Note that the current code only runs 2 chunks out of 40 (let's change this when producing figures for the paper). Also, it currently only runs it for the model in the repo - we will have to run it in the same way for an older model version and modify the code slightly to assemble the data from both runs. Note that this PR was based on the hart2015 PR since that code was needed before it was approved.
I hereby confirm that I have:
develop
as a target branch