Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra throws in pTest removed #846

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Extra throws in pTest removed #846

merged 1 commit into from
Jan 5, 2021

Conversation

evgueni-ovtchinnikov
Copy link
Contributor

aims to fix #842

KrisThielemans
KrisThielemans reviewed Jan 4, 2021
View reviewed changes
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally would have a test for pTest but maybe not to easy (intentionally have a test that fails, and if so, the pTesttest succeeds!)

src/common/Utilities.py
@@ -231,14 +231,16 @@ def show_3D_array\
return 0


def check_tolerance(expected, actual, abstol=0, reltol=1e-4):
def check_tolerance(expected, actual, abstol=0, reltol=2e-3):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional to decrease default tolerance in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taken from #844

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. confusing to mix the 2 PRs (might generate a conflict) but fine for me.

@evgueni-ovtchinnikov
Copy link
Contributor Author

@KrisThielemans re testing pTest: done manually by introducing errors in some test scripts and making sure they are reported by both ctest and run_all.py, with all good tests run unaffected

@KrisThielemans
Copy link
Member

@KrisThielemans re testing pTest: done manually by introducing errors in some test scripts and making sure they are reported by both ctest and run_all.py, with all good tests run unaffected

Not ideal, but certainly good enough for me, given our priority list. Feel free to merge this whenever Travis is happy (enough).

@evgueni-ovtchinnikov evgueni-ovtchinnikov merged commit 15ae80a into master Jan 5, 2021
@evgueni-ovtchinnikov evgueni-ovtchinnikov deleted the fix-ptest-throws branch January 19, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrisThielemans KrisThielemans KrisThielemans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pTest problem with __del__ and exceptions
2 participants
@evgueni-ovtchinnikov @KrisThielemans