PET tests tolerance fixes #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pTest is mostly set-up for comparing with recorded values. However, in many cases, we know what the value should be, and it is therefore better to make that part of the test. Aside from being clearer, it makes it also less dependent on where/how the recording was run.
This was referenced Dec 28, 2020
evgueni-ovtchinnikov
requested changes
Jan 4, 2021
|
@evgueni-ovtchinnikov Great idea! want to make that change yourself? You should be able to push to this branch (have to add https://github.com/KrisThielemans/SIRF as remote). Or I can do it later. let me know. |
|
@KrisThielemans: I am fixing #842 at the moment, which will affect your fixes, so will deal with this PR a bit later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #843