Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscodium images for new amalthea #478

Merged
merged 20 commits into from
Nov 27, 2024
Merged

feat: add vscodium images for new amalthea #478

merged 20 commits into from
Nov 27, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Nov 22, 2024

No description provided.

@olevski olevski marked this pull request as draft November 22, 2024 14:36
@olevski olevski requested a review from rokroskar November 24, 2024 18:02
@olevski olevski marked this pull request as ready for review November 24, 2024 18:02
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @olevski! I tested it with 0.61.0 and it worked very easily. Just one question: why two different python images? Is it not possible to combine them?

.github/workflows/build-and-push-to-docker.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-push-to-docker.yml Outdated Show resolved Hide resolved
docker/vscode/conda.Dockerfile Outdated Show resolved Hide resolved
.github/workflows/build-and-push-to-docker.yml Outdated Show resolved Hide resolved
@olevski
Copy link
Member Author

olevski commented Nov 25, 2024

Just one question: why two different python images? Is it not possible to combine them?

@rokroskar you mean why do we have a conda and a poetry image? I think combining them will bring more headaches than usefulness. Because I have no clue what happens if you try to use poetry in a conda env or vice versa. So I kept them separate.

Also I could not figure out how to force the base package in conda to contain a specific python version. So the conda image is just tied to the conda version and whatever version of python comes with that by default. But in the conda version it is very easy for people to install another python version.

@rokroskar
Copy link
Member

Just one question: why two different python images? Is it not possible to combine them?

@rokroskar you mean why do we have a conda and a poetry image? I think combining them will bring more headaches than usefulness. Because I have no clue what happens if you try to use poetry in a conda env or vice versa. So I kept them separate.

Also I could not figure out how to force the base package in conda to contain a specific python version. So the conda image is just tied to the conda version and whatever version of python comes with that by default. But in the conda version it is very easy for people to install another python version.

You can pin the version of python - I believe the base jupyter image that we've been using does this here

@olevski
Copy link
Member Author

olevski commented Nov 25, 2024

You can pin the version of python - I believe the base jupyter image that we've been using does this here

@rokroskar that does not work since I am using the conda installer and that one (i.e. the install.sh script) ignores the python version passed in. The script you linked uses the micromamba executable to do the installation. I will try to switch to micromamba.

@olevski
Copy link
Member Author

olevski commented Nov 25, 2024

Ok I am currently hitting:

Run docker/[email protected]
Docker info
Pulling binfmt Docker image
Error: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

So I will wait a bit then restart.

@olevski olevski requested a review from rokroskar November 26, 2024 07:38
rokroskar
rokroskar previously approved these changes Nov 27, 2024
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment - I think some text is left-over from the earlier version using microsoft images

docker/vscode/README.md Outdated Show resolved Hide resolved
@olevski olevski merged commit d1466a2 into main Nov 27, 2024
64 checks passed
@olevski olevski deleted the feat-add-vscodium branch November 27, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants