-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vscodium images for new amalthea #478
Conversation
481d161
to
4b7ab43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @olevski! I tested it with 0.61.0 and it worked very easily. Just one question: why two different python images? Is it not possible to combine them?
@rokroskar you mean why do we have a conda and a poetry image? I think combining them will bring more headaches than usefulness. Because I have no clue what happens if you try to use poetry in a conda env or vice versa. So I kept them separate. Also I could not figure out how to force the base package in conda to contain a specific python version. So the conda image is just tied to the conda version and whatever version of python comes with that by default. But in the conda version it is very easy for people to install another python version. |
You can pin the version of python - I believe the base jupyter image that we've been using does this here |
@rokroskar that does not work since I am using the conda installer and that one (i.e. the install.sh script) ignores the python version passed in. The script you linked uses the micromamba executable to do the installation. I will try to switch to micromamba. |
Ok I am currently hitting:
So I will wait a bit then restart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment - I think some text is left-over from the earlier version using microsoft images
No description provided.